This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push: new 7746c20 [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module 7746c20 is described below commit 7746c20ce73887876f19d66d48077608c1cf2575 Author: Peter Toth <peter.t...@gmail.com> AuthorDate: Fri Sep 18 13:56:19 2020 -0700 [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module ### What changes were proposed in this pull request? This is a follow-up PR to https://github.com/apache/spark/pull/29771 and just adds a new test case. ### Why are the changes needed? To have better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New UT. Closes #29802 from peter-toth/SPARK-32635-fix-foldable-propagation-followup. Authored-by: Peter Toth <peter.t...@gmail.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> (cherry picked from commit 3309a2be071f2d3f6122f3634aea998d6fa53876) Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- .../sql/catalyst/optimizer/FoldablePropagationSuite.scala | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala index 0d48ecb..59dfd3a 100644 --- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala +++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala @@ -180,4 +180,16 @@ class FoldablePropagationSuite extends PlanTest { .select((Literal(1) + 3).as('res)).analyze comparePlans(optimized, correctAnswer) } + + test("SPARK-32635: Replace references with foldables coming only from the node's children") { + val leftExpression = 'a.int + val left = LocalRelation(leftExpression).select('a) + val rightExpression = Alias(Literal(2), "a")(leftExpression.exprId) + val right = LocalRelation('b.int).select('b, rightExpression).select('b) + val join = left.join(right, joinType = LeftOuter, condition = Some('b === 'a)) + + val query = join.analyze + val optimized = Optimize.execute(query) + comparePlans(optimized, query) + } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org