This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push: new 70c0bc9 [SPARK-33819][CORE][FOLLOWUP][3.0] Restore the constructor of SingleFileEventLogFileReader to remove Mima exclusion 70c0bc9 is described below commit 70c0bc9a3358fc36b967cc28ae9232fe7437ab6a Author: Dongjoon Hyun <dongj...@apache.org> AuthorDate: Mon Jan 18 14:31:17 2021 +0900 [SPARK-33819][CORE][FOLLOWUP][3.0] Restore the constructor of SingleFileEventLogFileReader to remove Mima exclusion ### What changes were proposed in this pull request? This PR proposes to remove Mima exclusion via restoring the old constructor of SingleFileEventLogFileReader. This partially adopts the remaining parts of #30814 which was excluded while porting back. ### Why are the changes needed? To remove unnecessary Mima exclusion. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass CIs. Closes #31225 from HeartSaVioR/SPARK-33819-followup-branch-3.0. Authored-by: Dongjoon Hyun <dongj...@apache.org> Signed-off-by: HyukjinKwon <gurwls...@apache.org> --- .../scala/org/apache/spark/deploy/history/EventLogFileReaders.scala | 4 +++- project/MimaExcludes.scala | 5 +---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala index 6fe3a7b..b4771c8 100644 --- a/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala +++ b/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileReaders.scala @@ -167,9 +167,11 @@ object EventLogFileReader { private[history] class SingleFileEventLogFileReader( fs: FileSystem, path: Path, - maybeStatus: Option[FileStatus] = None) extends EventLogFileReader(fs, path) { + maybeStatus: Option[FileStatus]) extends EventLogFileReader(fs, path) { private lazy val status = maybeStatus.getOrElse(fileSystem.getFileStatus(rootPath)) + def this(fs: FileSystem, path: Path) = this(fs, path, None) + override def lastIndex: Option[Long] = None override def fileSizeForLastIndex: Long = status.getLen diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala index b4e36dc..b799624 100644 --- a/project/MimaExcludes.scala +++ b/project/MimaExcludes.scala @@ -461,10 +461,7 @@ object MimaExcludes { ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.streaming.StreamingQueryListener#QueryStartedEvent.this"), // [SPARK-30667][CORE] Add allGather method to BarrierTaskContext - ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.RequestToSync"), - - // [SPARK-33790][CORE] Reduce the rpc call of getFileStatus in SingleFileEventLogFileReader - ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.deploy.history.SingleFileEventLogFileReader.this") + ProblemFilters.exclude[IncompatibleTemplateDefProblem]("org.apache.spark.RequestToSync") ) // Exclude rules for 2.4.x --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org