This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.1 by this push: new 424fd2b [MINOR][SQL] Remove unnecessary extend from BroadcastHashJoinExec 424fd2b is described below commit 424fd2b6c61add08849b14e6b2a81737a8a013c5 Author: Cheng Su <chen...@fb.com> AuthorDate: Wed Mar 10 23:38:53 2021 -0800 [MINOR][SQL] Remove unnecessary extend from BroadcastHashJoinExec ### What changes were proposed in this pull request? This is just a minor fix. `HashJoin` already extends `JoinCodegenSupport`. So we don't need `CodegenSupport` here for `BroadcastHashJoinExec`. Submitted separately as a PR here per https://github.com/apache/spark/pull/31802#discussion_r592066686 . ### Why are the changes needed? Clean up code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. Closes #31805 from c21/bhj-minor. Authored-by: Cheng Su <chen...@fb.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> (cherry picked from commit 14ad7afa1aa0f3bfd75f1bf076a27af792721190) Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- .../org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala index 2a9e158..cec1286 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala @@ -46,7 +46,7 @@ case class BroadcastHashJoinExec( left: SparkPlan, right: SparkPlan, isNullAwareAntiJoin: Boolean = false) - extends HashJoin with CodegenSupport { + extends HashJoin { if (isNullAwareAntiJoin) { require(leftKeys.length == 1, "leftKeys length should be 1") --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org