This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.1 by this push:
     new 77802d9  [SPARK-35584][CORE][TESTS] Increase the timeout in 
FallbackStorageSuite
77802d9 is described below

commit 77802d9643bf9b800e1c4ac4e6c6b0c2fabdd2cd
Author: Yikun Jiang <yikunk...@gmail.com>
AuthorDate: Tue Jun 1 00:45:58 2021 -0700

    [SPARK-35584][CORE][TESTS] Increase the timeout in FallbackStorageSuite
    
    ### What changes were proposed in this pull request?
    ```
    - Upload multi stages *** FAILED ***
    {{ The code passed to eventually never returned normally. Attempted 20 
times over 10.011176743 seconds. Last failure message: 
fallbackStorage.exists(0, file) was false. (FallbackStorageSuite.scala:243)}}
    ```
    The error like above was raised in aarch64 randomly and also in github 
action test[1][2].
    
    [1] https://github.com/apache/spark/actions/runs/489319612
    [2]https://github.com/apache/spark/actions/runs/479317320
    
    ### Why are the changes needed?
    timeout is too short, need to increase to let test case complete.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    build/mvn test -Dtest=none 
-DwildcardSuites=org.apache.spark.storage.FallbackStorageSuite -pl 
:spark-core_2.12
    
    Closes #32719 from Yikun/SPARK-35584.
    
    Authored-by: Yikun Jiang <yikunk...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit d77337307489978b0523fcca27e60093bcc2df38)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../test/scala/org/apache/spark/storage/FallbackStorageSuite.scala    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/core/src/test/scala/org/apache/spark/storage/FallbackStorageSuite.scala 
b/core/src/test/scala/org/apache/spark/storage/FallbackStorageSuite.scala
index c07edb6..f155788 100644
--- a/core/src/test/scala/org/apache/spark/storage/FallbackStorageSuite.scala
+++ b/core/src/test/scala/org/apache/spark/storage/FallbackStorageSuite.scala
@@ -221,7 +221,7 @@ class FallbackStorageSuite extends SparkFunSuite with 
LocalSparkContext {
         sched.decommissionExecutor(_, ExecutorDecommissionInfo(""), false)
       }
 
-      eventually(timeout(10.seconds), interval(1.seconds)) {
+      eventually(timeout(20.seconds), interval(1.seconds)) {
         shuffle0_files.foreach { file => assert(fallbackStorage.exists(0, 
file)) }
         shuffle1_files.foreach { file => assert(fallbackStorage.exists(1, 
file)) }
       }
@@ -246,7 +246,7 @@ class FallbackStorageSuite extends SparkFunSuite with 
LocalSparkContext {
 
         // Make it sure that fallback storage are ready
         val fallbackStorage = new FallbackStorage(sc.getConf)
-        eventually(timeout(10.seconds), interval(1.seconds)) {
+        eventually(timeout(20.seconds), interval(1.seconds)) {
           Seq(
             "shuffle_0_0_0.index", "shuffle_0_0_0.data",
             "shuffle_0_1_0.index", "shuffle_0_1_0.data").foreach { file =>

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to