This is an automated email from the ASF dual-hosted git repository. gengliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new dc85b0b [SPARK-35950][WEBUI] Failed to toggle Exec Loss Reason in the executors page dc85b0b is described below commit dc85b0b51a02b9d6c52ffb1600f26ccdd7d7829a Author: Kevin Su <pings...@gmail.com> AuthorDate: Thu Jul 1 12:32:54 2021 +0800 [SPARK-35950][WEBUI] Failed to toggle Exec Loss Reason in the executors page ### What changes were proposed in this pull request? Update the executor's page, so it can successfully hide the "Exec Loss Reason" column. ### Why are the changes needed? When unselected the checkbox "Exec Loss Reason" on the executor page, the "Active tasks" column disappears instead of the "Exec Loss Reason" column. Before: ![Screenshot from 2021-06-30 15-55-05](https://user-images.githubusercontent.com/37936015/123930908-bd6f4180-d9c2-11eb-9aba-bbfe0a237776.png) After: ![Screenshot from 2021-06-30 22-21-38](https://user-images.githubusercontent.com/37936015/123977632-bf042e00-d9f1-11eb-910e-93d615d2db47.png) ### Does this PR introduce _any_ user-facing change? Yes, The Web UI is updated. ### How was this patch tested? Pass the CIs. Closes #33155 from pingsutw/SPARK-35950. Lead-authored-by: Kevin Su <pings...@gmail.com> Co-authored-by: Kevin Su <pings...@apache.org> Signed-off-by: Gengliang Wang <gengli...@apache.org> --- .../src/main/resources/org/apache/spark/ui/static/executorspage.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js index ab412a8..b7fbe04 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/executorspage.js +++ b/core/src/main/resources/org/apache/spark/ui/static/executorspage.js @@ -140,7 +140,7 @@ function totalDurationColor(totalGCTime, totalDuration) { } var sumOptionalColumns = [3, 4]; -var execOptionalColumns = [5, 6, 7, 8, 9, 10, 13, 14, 15]; +var execOptionalColumns = [5, 6, 7, 8, 9, 10, 13, 14, 25]; var execDataTable; var sumDataTable; @@ -566,7 +566,8 @@ $(document).ready(function () { {"visible": false, "targets": 9}, {"visible": false, "targets": 10}, {"visible": false, "targets": 13}, - {"visible": false, "targets": 14} + {"visible": false, "targets": 14}, + {"visible": false, "targets": 25} ], "deferRender": true }; @@ -721,7 +722,7 @@ $(document).ready(function () { "<div id='direct_mapped_pool_memory' class='direct_mapped_pool_memory-checkbox-div'><input type='checkbox' class='toggle-vis' data-sum-col-idx='' data-exec-col-idx='10'> Peak Pool Memory Direct / Mapped</div>" + "<div id='extra_resources' class='resources-checkbox-div'><input type='checkbox' class='toggle-vis' data-sum-col-idx='' data-exec-col-idx='13'> Resources</div>" + "<div id='resource_prof_id' class='resource-prof-id-checkbox-div'><input type='checkbox' class='toggle-vis' data-sum-col-idx='' data-exec-col-idx='14'> Resource Profile Id</div>" + - "<div id='exec_loss_reason' class='exec-loss-reason-checkbox-div'><input type='checkbox' class='toggle-vis' data-sum-col-idx='' data-exec-col-idx='15'> Exec Loss Reason</div>" + + "<div id='exec_loss_reason' class='exec-loss-reason-checkbox-div'><input type='checkbox' class='toggle-vis' data-sum-col-idx='' data-exec-col-idx='25'> Exec Loss Reason</div>" + "</div>"); reselectCheckboxesBasedOnTaskTableState(); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org