This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new d5fa5cba4f5 [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`
d5fa5cba4f5 is described below

commit d5fa5cba4f55df40a54cdffdf446b69e7aff3182
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Thu Jun 16 09:25:41 2022 +0900

    [SPARK-39468][CORE][FOLLOWUP] Use `lazy val` for `host`
    
    ### What changes were proposed in this pull request?
    
    This PR aims to use `lazy val host` instead of `val host`.
    
    ### Why are the changes needed?
    
    To address the review comments about `RpcAddress` object size.
    - https://github.com/apache/spark/pull/36868#discussion_r898235985
    - https://github.com/apache/spark/pull/36868#discussion_r898332785
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Pass the CIs.
    
    Closes #36882 from dongjoon-hyun/SPARK-39468-2.
    
    Authored-by: Dongjoon Hyun <dongj...@apache.org>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 core/src/main/scala/org/apache/spark/rpc/RpcAddress.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/scala/org/apache/spark/rpc/RpcAddress.scala 
b/core/src/main/scala/org/apache/spark/rpc/RpcAddress.scala
index 2a2d2051799..9b0739c9447 100644
--- a/core/src/main/scala/org/apache/spark/rpc/RpcAddress.scala
+++ b/core/src/main/scala/org/apache/spark/rpc/RpcAddress.scala
@@ -25,7 +25,7 @@ import org.apache.spark.util.Utils
  */
 private[spark] case class RpcAddress(_host: String, port: Int) {
 
-  val host: String = Utils.addBracketsIfNeeded(_host)
+  lazy val host: String = Utils.addBracketsIfNeeded(_host)
 
   def hostPort: String = host + ":" + port
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to