This is an automated email from the ASF dual-hosted git repository. sunchao pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.3 by this push: new 7e2a1827757 [SPARK-37205][FOLLOWUP] Should call non-static setTokensConf method 7e2a1827757 is described below commit 7e2a1827757a8c0e356ab795387f094e81f5f37e Author: Chao Sun <sunc...@apple.com> AuthorDate: Thu Jun 30 23:18:06 2022 -0700 [SPARK-37205][FOLLOWUP] Should call non-static setTokensConf method ### What changes were proposed in this pull request? This fixes a bug in the original SPARK-37205 PR, where we treat the method `setTokensConf` as a static method, but it should be non-static instead. ### Why are the changes needed? The method `setTokensConf` is non-static so the current code will fail: ``` 06/29/2022 - 17:28:16 - Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 06/29/2022 - 17:28:16 - at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 06/29/2022 - 17:28:16 - at java.base/java.lang.reflect.Method.invoke(Method.java:566) ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually tested this change internally and it now works. Closes #37037 from sunchao/SPARK-37205-fix. Authored-by: Chao Sun <sunc...@apple.com> Signed-off-by: Chao Sun <sunc...@apple.com> --- .../yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala index f364b792160..5402c503908 100644 --- a/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala +++ b/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala @@ -391,7 +391,7 @@ private[spark] class Client( throw new SparkException(s"Cannot find setTokensConf method in ${amContainer.getClass}." + s" Please check YARN version and make sure it is 2.9+ or 3.x") } - setTokensConfMethod.invoke(ByteBuffer.wrap(dob.getData)) + setTokensConfMethod.invoke(amContainer, ByteBuffer.wrap(dob.getData)) } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org