This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new dfcf2a8b456 [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode dfcf2a8b456 is described below commit dfcf2a8b45679ed3e89fd0f3bfdb25c8043bee3e Author: Angerszhuuuu <angers....@gmail.com> AuthorDate: Wed Aug 3 11:19:52 2022 +0900 [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode ### What changes were proposed in this pull request? The current verbose string of LogicalPlan didn't contain join type, we should add this ``` (10) BroadcastHashJoin [codegen id : 4] Left keys [1]: [ws_sold_date_sk#7] Right keys [1]: [d_date_sk#9] Join type: Inner Join condition: None ``` ### Why are the changes needed? Add missed join type in verbose plan ### Does this PR introduce _any_ user-facing change? User can see join type in verbose plan string ### How was this patch tested? Existed UT Closes #37378 from AngersZhuuuu/SPARK-39776-FOLLOW_UP. Authored-by: Angerszhuuuu <angers....@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- .../approved-plans-v1_4/q83.ansi/explain.txt | 10 ++++++++++ .../approved-plans-v1_4/q83.sf100.ansi/explain.txt | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.ansi/explain.txt b/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.ansi/explain.txt index 905d29293a3..d0246aa1c9b 100644 --- a/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.ansi/explain.txt +++ b/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.ansi/explain.txt @@ -83,6 +83,7 @@ Arguments: HashedRelationBroadcastMode(List(cast(input[0, int, false] as bigint) (8) BroadcastHashJoin [codegen id : 5] Left keys [1]: [sr_item_sk#1] Right keys [1]: [i_item_sk#5] +Join type: Inner Join condition: None (9) Project [codegen id : 5] @@ -95,6 +96,7 @@ Output [1]: [d_date_sk#7] (11) BroadcastHashJoin [codegen id : 5] Left keys [1]: [sr_returned_date_sk#3] Right keys [1]: [d_date_sk#7] +Join type: Inner Join condition: None (12) Project [codegen id : 5] @@ -140,6 +142,7 @@ Output [2]: [i_item_sk#16, i_item_id#17] (20) BroadcastHashJoin [codegen id : 10] Left keys [1]: [cr_item_sk#13] Right keys [1]: [i_item_sk#16] +Join type: Inner Join condition: None (21) Project [codegen id : 10] @@ -152,6 +155,7 @@ Output [1]: [d_date_sk#18] (23) BroadcastHashJoin [codegen id : 10] Left keys [1]: [cr_returned_date_sk#15] Right keys [1]: [d_date_sk#18] +Join type: Inner Join condition: None (24) Project [codegen id : 10] @@ -183,6 +187,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, string, true]),false), [pla (29) BroadcastHashJoin [codegen id : 18] Left keys [1]: [item_id#11] Right keys [1]: [item_id#22] +Join type: Inner Join condition: None (30) Project [codegen id : 18] @@ -210,6 +215,7 @@ Output [2]: [i_item_sk#27, i_item_id#28] (35) BroadcastHashJoin [codegen id : 16] Left keys [1]: [wr_item_sk#24] Right keys [1]: [i_item_sk#27] +Join type: Inner Join condition: None (36) Project [codegen id : 16] @@ -222,6 +228,7 @@ Output [1]: [d_date_sk#29] (38) BroadcastHashJoin [codegen id : 16] Left keys [1]: [wr_returned_date_sk#26] Right keys [1]: [d_date_sk#29] +Join type: Inner Join condition: None (39) Project [codegen id : 16] @@ -253,6 +260,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, string, true]),false), [pla (44) BroadcastHashJoin [codegen id : 18] Left keys [1]: [item_id#11] Right keys [1]: [item_id#33] +Join type: Inner Join condition: None (45) Project [codegen id : 18] @@ -332,6 +340,7 @@ Arguments: HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)) (57) BroadcastHashJoin [codegen id : 2] Left keys [1]: [d_week_seq#41] Right keys [1]: [d_week_seq#43] +Join type: LeftSemi Join condition: None (58) Project [codegen id : 2] @@ -345,6 +354,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, date, true]),false), [plan_ (60) BroadcastHashJoin [codegen id : 3] Left keys [1]: [d_date#39] Right keys [1]: [d_date#40] +Join type: LeftSemi Join condition: None (61) Project [codegen id : 3] diff --git a/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.sf100.ansi/explain.txt b/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.sf100.ansi/explain.txt index e6a65be7ec4..746f0afa87a 100644 --- a/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.sf100.ansi/explain.txt +++ b/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q83.sf100.ansi/explain.txt @@ -68,6 +68,7 @@ Output [1]: [d_date_sk#5] (5) BroadcastHashJoin [codegen id : 5] Left keys [1]: [sr_returned_date_sk#3] Right keys [1]: [d_date_sk#5] +Join type: Inner Join condition: None (6) Project [codegen id : 5] @@ -95,6 +96,7 @@ Arguments: HashedRelationBroadcastMode(List(cast(input[0, int, false] as bigint) (11) BroadcastHashJoin [codegen id : 5] Left keys [1]: [sr_item_sk#1] Right keys [1]: [i_item_sk#6] +Join type: Inner Join condition: None (12) Project [codegen id : 5] @@ -140,6 +142,7 @@ Output [1]: [d_date_sk#16] (20) BroadcastHashJoin [codegen id : 10] Left keys [1]: [cr_returned_date_sk#15] Right keys [1]: [d_date_sk#16] +Join type: Inner Join condition: None (21) Project [codegen id : 10] @@ -152,6 +155,7 @@ Output [2]: [i_item_sk#17, i_item_id#18] (23) BroadcastHashJoin [codegen id : 10] Left keys [1]: [cr_item_sk#13] Right keys [1]: [i_item_sk#17] +Join type: Inner Join condition: None (24) Project [codegen id : 10] @@ -183,6 +187,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, string, true]),false), [pla (29) BroadcastHashJoin [codegen id : 18] Left keys [1]: [item_id#11] Right keys [1]: [item_id#22] +Join type: Inner Join condition: None (30) Project [codegen id : 18] @@ -210,6 +215,7 @@ Output [1]: [d_date_sk#27] (35) BroadcastHashJoin [codegen id : 16] Left keys [1]: [wr_returned_date_sk#26] Right keys [1]: [d_date_sk#27] +Join type: Inner Join condition: None (36) Project [codegen id : 16] @@ -222,6 +228,7 @@ Output [2]: [i_item_sk#28, i_item_id#29] (38) BroadcastHashJoin [codegen id : 16] Left keys [1]: [wr_item_sk#24] Right keys [1]: [i_item_sk#28] +Join type: Inner Join condition: None (39) Project [codegen id : 16] @@ -253,6 +260,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, string, true]),false), [pla (44) BroadcastHashJoin [codegen id : 18] Left keys [1]: [item_id#11] Right keys [1]: [item_id#33] +Join type: Inner Join condition: None (45) Project [codegen id : 18] @@ -332,6 +340,7 @@ Arguments: HashedRelationBroadcastMode(List(cast(input[0, int, true] as bigint)) (57) BroadcastHashJoin [codegen id : 2] Left keys [1]: [d_week_seq#41] Right keys [1]: [d_week_seq#43] +Join type: LeftSemi Join condition: None (58) Project [codegen id : 2] @@ -345,6 +354,7 @@ Arguments: HashedRelationBroadcastMode(List(input[0, date, true]),false), [plan_ (60) BroadcastHashJoin [codegen id : 3] Left keys [1]: [d_date#39] Right keys [1]: [d_date#40] +Join type: LeftSemi Join condition: None (61) Project [codegen id : 3] --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org