[GitHub] [spark-website] viirya commented on a diff in pull request #424: Use docker image in the example of SQL/Scala/Java

[GitBox]

viirya commented on code in PR #424:
URL: https://github.com/apache/spark-website/pull/424#discussion_r1008731927


##########
index.md:
##########
@@ -155,7 +155,7 @@ filtered_df.summary().show()
             <div class="tab-pane fade" id="nav-sql" role="tabpanel" 
aria-labelledby="nav-sql-tab">
                 <div class="mb-2 title">Run now</div>
                 <div class="code">
-                    <p>$ SPARK-HOME/bin/spark-sql</p>
+                    <p>$ docker run -it apache/spark 
/opt/spark/bin/spark-sql</p>

Review Comment:
   nit:
   
   ```suggestion
                       <p>$ docker run -it --rm apache/spark 
/opt/spark/bin/spark-sql</p>
   ```



##########
index.md:
##########
@@ -175,7 +175,7 @@ FROM json.`logs.json`
             <div class="tab-pane fade" id="nav-scala" role="tabpanel" 
aria-labelledby="nav-scala-tab">
                 <div class="mb-2 title">Run now</div>
                 <div class="code">
-                    <p>$ SPARK-HOME/bin/spark-shell</p>
+                    <p>$ docker run -it apache/spark 
/opt/spark/bin/spark-shell</p>

Review Comment:
   ```suggestion
                       <p>$ docker run -it --rm apache/spark 
/opt/spark/bin/spark-shell</p>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org