This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.2 by this push:
     new ddccb6fbe2c [SPARK-41091][BUILD][3.2] Fix Docker release tool for 
branch-3.2
ddccb6fbe2c is described below

commit ddccb6fbe2cc9dd784ea94376017acc18fc15abf
Author: Chao Sun <sunc...@apple.com>
AuthorDate: Sun Nov 13 22:27:12 2022 -0800

    [SPARK-41091][BUILD][3.2] Fix Docker release tool for branch-3.2
    
    ### What changes were proposed in this pull request?
    
    This tries to fix `do-release-docker.sh` for branch-3.2.
    
    ### Why are the changes needed?
    
    Currently the following error will occur if running the script in 
`branch-3.2`:
    ```
    #5 917.4 g++ -std=gnu++14 -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions 
-Wl,-z,relro -o testthat.so init.o reassign.o test-catch.o test-example.o 
test-runner.o -L/usr/lib/R/lib -lR
    #5 917.5 installing to 
/usr/local/lib/R/site-library/00LOCK-testthat/00new/testthat/libs
    #5 917.5 ** R
    #5 917.5 ** inst
    #5 917.5 ** byte-compile and prepare package for lazy loading
    #5 924.4 ** help
    #5 924.6 *** installing help indices
    #5 924.7 *** copying figures
    #5 924.7 ** building package indices
    #5 924.9 ** installing vignettes
    #5 924.9 ** testing if installed package can be loaded from temporary 
location
    #5 925.1 ** checking absolute paths in shared objects and dynamic libraries
    #5 925.1 ** testing if installed package can be loaded from final location
    #5 925.5 ** testing if installed package keeps a record of temporary 
installation path
    #5 925.5 * DONE (testthat)
    #5 925.8 ERROR: dependency 'pkgdown' is not available for package 'devtools'
    #5 925.8 * removing '/usr/local/lib/R/site-library/devtools'
    #5 925.8
    #5 925.8 The downloaded source packages are in
    #5 925.8        '/tmp/Rtmp3nJI60/downloaded_packages'
    #5 925.8 Warning messages:
    #5 925.8 1: In install.packages(c("curl", "xml2", "httr", "devtools", 
"testthat",  :
    #5 925.8   installation of package 'textshaping' had non-zero exit status
    #5 925.8 2: In install.packages(c("curl", "xml2", "httr", "devtools", 
"testthat",  :
    #5 925.8   installation of package 'ragg' had non-zero exit status
    #5 925.8 3: In install.packages(c("curl", "xml2", "httr", "devtools", 
"testthat",  :
    #5 925.8   installation of package 'pkgdown' had non-zero exit status
    #5 925.8 4: In install.packages(c("curl", "xml2", "httr", "devtools", 
"testthat",  :
    #5 925.8   installation of package 'devtools' had non-zero exit status
    #5 926.0 Error in loadNamespace(x) : there is no package called 'devtools'
    #5 926.0 Calls: loadNamespace -> withRestarts -> withOneRestart -> 
doWithOneRestart
    #5 926.0 Execution halted
    ```
    
    The same error doesn't happen on master. I checked the diff between the two 
and it seems the following line:
    ```
    $APT_INSTALL libfontconfig1-dev libharfbuzz-dev libfribidi-dev 
libfreetype6-dev libpng-dev libtiff5-dev libjpeg-dev && \
    ```
    
    introduced in https://github.com/apache/spark/pull/34728 made the 
difference.
    
    I verified that after adding the line, `do-release-docker.sh` (dry run 
mode) was able to finish successfully.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Manually
    
    Closes #38643 from sunchao/fix-docker-release.
    
    Authored-by: Chao Sun <sunc...@apple.com>
    Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
 dev/create-release/spark-rm/Dockerfile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dev/create-release/spark-rm/Dockerfile 
b/dev/create-release/spark-rm/Dockerfile
index 5b986fd96ab..5c5c22b7cdf 100644
--- a/dev/create-release/spark-rm/Dockerfile
+++ b/dev/create-release/spark-rm/Dockerfile
@@ -80,6 +80,7 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg 
ca-certificates && \
   $APT_INSTALL r-base r-base-dev && \
   $APT_INSTALL libcurl4-openssl-dev libgit2-dev libssl-dev libxml2-dev && \
   $APT_INSTALL texlive-latex-base texlive texlive-fonts-extra texinfo qpdf 
texlive-latex-extra && \
+  $APT_INSTALL libfontconfig1-dev libharfbuzz-dev libfribidi-dev 
libfreetype6-dev libpng-dev libtiff5-dev libjpeg-dev && \
   Rscript -e "install.packages(c('curl', 'xml2', 'httr', 'devtools', 
'testthat', 'knitr', 'rmarkdown', 'markdown', 'roxygen2', 'e1071', 'survival'), 
repos='https://cloud.r-project.org/')" && \
   Rscript -e "devtools::install_github('jimhester/lintr')" && \
   # Install tools needed to build the documentation.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to