This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new f8ad5e307b4 [MINOR][SQL] Remove redundant comment in CTESubstitution f8ad5e307b4 is described below commit f8ad5e307b4686f4c22dc47ba8dc2866fe55476b Author: Reynold Xin <r...@databricks.com> AuthorDate: Sat Dec 24 08:37:49 2022 +0900 [MINOR][SQL] Remove redundant comment in CTESubstitution ### What changes were proposed in this pull request? I think the proposed removal is just a duplicate of the next point. I actually spent couple minutes trying to understand if there was a difference. ### Why are the changes needed? See above. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This is a code comment change. Closes #39197 from rxin/cte_substitution_comment. Authored-by: Reynold Xin <r...@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- .../org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala index 6a4562450b9..77c687843c3 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala @@ -157,14 +157,6 @@ object CTESubstitution extends Rule[LogicalPlan] { * SELECT * FROM t * ) * SELECT * FROM t2 - * - If a CTE definition contains a subquery that contains an inner WITH node then substitution - * of inner should take precedence because it can shadow an outer CTE definition. - * For example the following query should return 2: - * WITH t AS (SELECT 1 AS c) - * SELECT max(c) FROM ( - * WITH t AS (SELECT 2 AS c) - * SELECT * FROM t - * ) * - If a CTE definition contains a subquery expression that contains an inner WITH node then * substitution of inner should take precedence because it can shadow an outer CTE * definition. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org