This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 3c7fb30f61f [SPARK-41825][CONNECT][PYTHON] Enable doctests related to
`DataFrame.show`
3c7fb30f61f is described below
commit 3c7fb30f61f51532dce8d15600215afd2f2ff019
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Thu Jan 5 12:19:22 2023 +0900
[SPARK-41825][CONNECT][PYTHON] Enable doctests related to `DataFrame.show`
### What changes were proposed in this pull request?
enable a group of doctests
### Why are the changes needed?
for test coverage
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
enabled tests
Closes #39396 from zhengruifeng/connect_fix_41825.
Authored-by: Ruifeng Zheng <ruife...@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
python/pyspark/sql/connect/dataframe.py | 6 +-----
python/pyspark/sql/connect/functions.py | 4 ----
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/python/pyspark/sql/connect/dataframe.py
b/python/pyspark/sql/connect/dataframe.py
index fdb75d377b7..2464441bcf2 100644
--- a/python/pyspark/sql/connect/dataframe.py
+++ b/python/pyspark/sql/connect/dataframe.py
@@ -1427,11 +1427,7 @@ def _test() -> None:
del pyspark.sql.connect.dataframe.DataFrame.explain.__doc__
del pyspark.sql.connect.dataframe.DataFrame.hint.__doc__
- # TODO(SPARK-41825): Dataframe.show formatting int as double
- del pyspark.sql.connect.dataframe.DataFrame.fillna.__doc__
- del pyspark.sql.connect.dataframe.DataFrameNaFunctions.replace.__doc__
- del pyspark.sql.connect.dataframe.DataFrameNaFunctions.fill.__doc__
- del pyspark.sql.connect.dataframe.DataFrame.replace.__doc__
+ # TODO(SPARK-41886): The doctest output has different order
del pyspark.sql.connect.dataframe.DataFrame.intersect.__doc__
# TODO(SPARK-41625): Support Structured Streaming
diff --git a/python/pyspark/sql/connect/functions.py
b/python/pyspark/sql/connect/functions.py
index 965a9a5331e..f2603d477cb 100644
--- a/python/pyspark/sql/connect/functions.py
+++ b/python/pyspark/sql/connect/functions.py
@@ -2360,10 +2360,6 @@ def _test() -> None:
del pyspark.sql.connect.functions.date_trunc.__doc__
del pyspark.sql.connect.functions.from_utc_timestamp.__doc__
- # TODO(SPARK-41825): Dataframe.show formatting int as double
- del pyspark.sql.connect.functions.coalesce.__doc__
- del pyspark.sql.connect.functions.sum_distinct.__doc__
-
# TODO(SPARK-41834): implement Dataframe.conf
del pyspark.sql.connect.functions.from_unixtime.__doc__
del pyspark.sql.connect.functions.timestamp_seconds.__doc__
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
