This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 6ca45c52b74 [MINOR][SQL] Fix comment in KeyGroupedPartitioning not
match with parameter
6ca45c52b74 is described below
commit 6ca45c52b7416e7b3520dc902cb24f060c7c72dd
Author: Jia Fan <fanjiaemi...@qq.com>
AuthorDate: Wed Jul 26 13:52:23 2023 +0900
[MINOR][SQL] Fix comment in KeyGroupedPartitioning not match with parameter
### What changes were proposed in this pull request?
Since #39540, change parameter `partitionValuesOpt` to `partitionValues`,
but didn't change comment on method.
### Why are the changes needed?
Fix comment not up to date.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
unnecessary.
Closes #42152 from Hisoka-X/small_doc_change_partitionValueOpt.
Authored-by: Jia Fan <fanjiaemi...@qq.com>
Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
.../apache/spark/sql/catalyst/plans/physical/partitioning.scala | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
index 6512344169b..bd8ba54ddd7 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
@@ -310,17 +310,17 @@ case class HashPartitioning(expressions: Seq[Expression],
numPartitions: Int)
/**
* Represents a partitioning where rows are split across partitions based on
transforms defined
- * by `expressions`. `partitionValuesOpt`, if defined, should contain value of
partition key(s) in
+ * by `expressions`. `partitionValues`, if defined, should contain value of
partition key(s) in
* ascending order, after evaluated by the transforms in `expressions`, for
each input partition.
* In addition, its length must be the same as the number of input partitions
(and thus is a 1-1
- * mapping), and each row in `partitionValuesOpt` must be unique.
+ * mapping), and each row in `partitionValues` must be unique.
*
- * For example, if `expressions` is `[years(ts_col)]`, then a valid value of
`partitionValuesOpt` is
+ * For example, if `expressions` is `[years(ts_col)]`, then a valid value of
`partitionValues` is
* `[0, 1, 2]`, which represents 3 input partitions with distinct partition
values. All rows
* in each partition have the same value for column `ts_col` (which is of
timestamp type), after
* being applied by the `years` transform.
*
- * On the other hand, `[0, 0, 1]` is not a valid value for
`partitionValuesOpt` since `0` is
+ * On the other hand, `[0, 0, 1]` is not a valid value for `partitionValues`
since `0` is
* duplicated twice.
*
* @param expressions partition expressions for the partitioning.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
