This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 994a3f14bc8 [SPARK-44593][INFRA] Make `breaking-changes-buf` cancelable
994a3f14bc8 is described below
commit 994a3f14bc8144eeae174fd09e384b86bb4b39ba
Author: Ruifeng Zheng <[email protected]>
AuthorDate: Sun Jul 30 10:57:13 2023 +0900
[SPARK-44593][INFRA] Make `breaking-changes-buf` cancelable
### What changes were proposed in this pull request?
Make `breaking-changes-buf` cancelable, refering to
https://docs.github.com/en/actions/learn-github-actions/expressions#always
> Warning: Avoid using always for any task that could suffer from a
critical failure, for example: getting sources, otherwise the workflow may hang
until it times out. If you want to run a job or step regardless of its success
or failure, use the recommended alternative: if: ${{ !cancelled() }}
### Why are the changes needed?
release the runner ASAP, when we click the `Cancel Workflow` button
see cenceled run:
https://github.com/zhengruifeng/spark/actions/runs/5697578362
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
manually check
Closes #42219 from zhengruifeng/infra_cancel_buf.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
.github/workflows/build_and_test.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index 02b3814a018..81d16dddde4 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -527,7 +527,7 @@ jobs:
breaking-changes-buf:
needs: [precondition]
- if: always() &&
fromJson(needs.precondition.outputs.required).breaking-changes-buf == 'true'
+ if: (!cancelled()) &&
fromJson(needs.precondition.outputs.required).breaking-changes-buf == 'true'
# Change 'branch-3.5' to 'branch-4.0' in master branch after cutting
branch-4.0 branch.
name: Breaking change detection with Buf (branch-3.5)
runs-on: ubuntu-22.04
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
