This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 39fc6108bfa [SPARK-45562][DOCS] Regenerate 
`docs/sql-error-conditions.md` and add `42KDF` to `SQLSTATE table` in 
`error/README.md`
39fc6108bfa is described below

commit 39fc6108bfaaa0ce471f6460880109f948ba5c62
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Wed Nov 15 09:04:25 2023 -0800

    [SPARK-45562][DOCS] Regenerate `docs/sql-error-conditions.md` and add 
`42KDF` to `SQLSTATE table` in `error/README.md`
    
    ### What changes were proposed in this pull request?
    This pr re-generate `docs/sql-error-conditions.md` and add `42KDF` to 
`SQLSTATE table` in `error/README.md` refer to 
https://docs.gcp.databricks.com/error-messages/sqlstates.html
    
    <img width="855" alt="image" 
src="https://github.com/apache/spark/assets/1475305/6e302ea5-fa61-40a3-99ef-7c6d63334194";>
    
    ### Why are the changes needed?
    Make GA pass
    
    https://github.com/apache/spark/actions/runs/6874376893/job/18695941494
    
    ```
    [info] - SQLSTATE invariants *** FAILED *** (30 milliseconds)
    [info]   fx.apply(s) was false 42KDF (SparkThrowableSuite.scala:74)
    [info]   org.scalatest.exceptions.TestFailedException:
    [info]   at 
org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
    [info]   at 
org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
    [info]   at 
org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
    [info]   at 
org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
    [info]   at 
org.apache.spark.SparkThrowableSuite.$anonfun$checkCondition$1(SparkThrowableSuite.scala:74)
    [info]   at scala.collection.immutable.List.foreach(List.scala:333)
    [info]   at 
org.apache.spark.SparkThrowableSuite.checkCondition(SparkThrowableSuite.scala:73)
    [info]   at 
org.apache.spark.SparkThrowableSuite.$anonfun$new$6(SparkThrowableSuite.scala:138)
    [info]   at 
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
    [info]   at 
org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
    ....
    [info] - Error classes match with document *** FAILED *** (71 milliseconds)
    [info]   "...gs-error-class.html)[
    [info]
    [info]   ### XML_ROW_TAG_MISSING
    [info]
    [info]   [SQLSTATE: 
42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
    [info]
    [info]   `<rowTag>` option is required for reading files in XML format.]" 
did not equal "...gs-error-class.html)[]" The error class document is not up to 
date. Please regenerate it. (SparkThrowableSuite.scala:346)
    [info]   Analysis:
    [info]   "...gs-error-class.html)[
    [info]
    [info] ### XML_ROW_TAG_MISSING
    [info]
    [info] [SQLSTATE: 
42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
    [info]
    [info] `<rowTag>` option is required for reading files in XML format.]" -> 
"...gs-error-class.html)[]"
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    
    - Pass GitHub Actions
    - Manual check `build/sbt   "core/testOnly *SparkThrowableSuite"`
    
    **Before**
    
    ```
    [info] Run completed in 1 second, 205 milliseconds.
    [info] Total number of tests run: 19
    [info] Suites: completed 1, aborted 0
    [info] Tests: succeeded 17, failed 2, canceled 0, ignored 0, pending 0
    [info] *** 2 TESTS FAILED ***
    [error] Failed tests:
    [error]         org.apache.spark.SparkThrowableSuite
    ```
    **After**
    
    ```
    [info] Run completed in 1 second, 131 milliseconds.
    [info] Total number of tests run: 19
    [info] Suites: completed 1, aborted 0
    [info] Tests: succeeded 19, failed 0, canceled 0, ignored 0, pending 0
    [info] All tests passed.
    ```
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #43817 from LuciferYang/SPARK-45562-FOLLOWUP.
    
    Authored-by: yangjie01 <yangji...@baidu.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 common/utils/src/main/resources/error/README.md | 1 +
 docs/sql-error-conditions.md                    | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/common/utils/src/main/resources/error/README.md 
b/common/utils/src/main/resources/error/README.md
index 8d8529bea56..7b1b9038aeb 100644
--- a/common/utils/src/main/resources/error/README.md
+++ b/common/utils/src/main/resources/error/README.md
@@ -895,6 +895,7 @@ The following SQLSTATEs are collated from:
 |42KDC    |42   |Syntax error or Access Rule violation             |KDC     
|Archived file reference.                                    |Databricks     |N 
      |Databricks                                                               
   |
 |42KDD    |42   |Syntax error or Access Rule violation             |KDD     
|Unsupported operation in streaming view.                    |Databricks     |N 
      |Databricks                                                               
   |
 |42KDE    |42   |Syntax error or Access Rule violation             |KDE     
|Unsupported operation on streaming dataset.                 |Databricks     |N 
      |Databricks                                                               
   |
+|42KDF    |42   |Syntax error or Access Rule violation             |KDF     |A 
required routine parameter is missing an argument.        |Databricks     |N    
   |Databricks                                                                  
|
 |42P01    |42   |Syntax error or Access Rule violation             |P01     
|undefined_table                                             |PostgreSQL     |N 
      |PostgreSQL Redshift                                                      
   |
 |42P02    |42   |Syntax Error or Access Rule Violation             |P02     
|undefined_parameter                                         |PostgreSQL     |N 
      |PostgreSQL Redshift                                                      
   |
 |42P03    |42   |Syntax Error or Access Rule Violation             |P03     
|duplicate_cursor                                            |PostgreSQL     |N 
      |PostgreSQL Redshift                                                      
   |
diff --git a/docs/sql-error-conditions.md b/docs/sql-error-conditions.md
index f23b4fb78b6..cba6a24b869 100644
--- a/docs/sql-error-conditions.md
+++ b/docs/sql-error-conditions.md
@@ -2375,3 +2375,9 @@ The operation `<operation>` requires a `<requiredType>`. 
But `<objectName>` is a
 The `<functionName>` requires `<expectedNum>` parameters but the actual number 
is `<actualNum>`.
 
 For more details see 
[WRONG_NUM_ARGS](sql-error-conditions-wrong-num-args-error-class.html)
+
+### XML_ROW_TAG_MISSING
+
+[SQLSTATE: 
42KDF](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation)
+
+`<rowTag>` option is required for reading files in XML format.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to