This is an automated email from the ASF dual-hosted git repository. ruifengz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 09365a5e3c2f [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` 09365a5e3c2f is described below commit 09365a5e3c2f223c15e2ba580ca6c90094235bf9 Author: Ruifeng Zheng <ruife...@apache.org> AuthorDate: Fri Dec 15 09:26:26 2023 +0800 [SPARK-45005][PS][TESTS][FOLLOWUPS] Deduplicate `test_properties` ### What changes were proposed in this pull request? `test_properties` in `pyspark.pandas.tests.indexes.test_datetime` was moved to `pyspark.pandas.tests.indexes.test_datetime_property` in https://github.com/apache/spark/commit/c76e3f61dd7b56dbff43bba7144df939c03f0f66 , but that commit forgot to remove it in `pyspark.pandas.tests.indexes.test_datetime`, so `test_properties` and its parity test are tested twice. ### Why are the changes needed? deduplicate test ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #44353 from zhengruifeng/ps_test_deduplicate_test_properties. Authored-by: Ruifeng Zheng <ruife...@apache.org> Signed-off-by: Ruifeng Zheng <ruife...@apache.org> --- .../pyspark/pandas/tests/indexes/test_datetime.py | 26 ---------------------- .../pandas/tests/indexes/test_datetime_property.py | 3 --- 2 files changed, 29 deletions(-) diff --git a/python/pyspark/pandas/tests/indexes/test_datetime.py b/python/pyspark/pandas/tests/indexes/test_datetime.py index 92f607623077..51c5103fd496 100644 --- a/python/pyspark/pandas/tests/indexes/test_datetime.py +++ b/python/pyspark/pandas/tests/indexes/test_datetime.py @@ -71,32 +71,6 @@ class DatetimeIndexTestsMixin: ): ps.DatetimeIndex(["2004-01-01", "2002-12-31", "2000-04-01"]).all() - def test_properties(self): - for psidx, pidx in self.idx_pairs: - self.assert_eq(psidx.year, pidx.year) - self.assert_eq(psidx.month, pidx.month) - self.assert_eq(psidx.day, pidx.day) - self.assert_eq(psidx.hour, pidx.hour) - self.assert_eq(psidx.minute, pidx.minute) - self.assert_eq(psidx.second, pidx.second) - self.assert_eq(psidx.microsecond, pidx.microsecond) - self.assert_eq(psidx.dayofweek, pidx.dayofweek) - self.assert_eq(psidx.weekday, pidx.weekday) - self.assert_eq(psidx.dayofyear, pidx.dayofyear) - self.assert_eq(psidx.quarter, pidx.quarter) - self.assert_eq(psidx.daysinmonth, pidx.daysinmonth) - self.assert_eq(psidx.days_in_month, pidx.days_in_month) - self.assert_eq(psidx.is_month_start, pd.Index(pidx.is_month_start)) - self.assert_eq(psidx.is_month_end, pd.Index(pidx.is_month_end)) - self.assert_eq(psidx.is_quarter_start, pd.Index(pidx.is_quarter_start)) - self.assert_eq(psidx.is_quarter_end, pd.Index(pidx.is_quarter_end)) - self.assert_eq(psidx.is_year_start, pd.Index(pidx.is_year_start)) - self.assert_eq(psidx.is_year_end, pd.Index(pidx.is_year_end)) - self.assert_eq(psidx.is_leap_year, pd.Index(pidx.is_leap_year)) - - self.assert_eq(psidx.day_of_year, pidx.day_of_year) - self.assert_eq(psidx.day_of_week, pidx.day_of_week) - def test_ceil(self): for psidx, pidx in self.idx_pairs: for freq in self.fixed_freqs: diff --git a/python/pyspark/pandas/tests/indexes/test_datetime_property.py b/python/pyspark/pandas/tests/indexes/test_datetime_property.py index 4c15a870488f..048f5d1462bf 100644 --- a/python/pyspark/pandas/tests/indexes/test_datetime_property.py +++ b/python/pyspark/pandas/tests/indexes/test_datetime_property.py @@ -14,9 +14,6 @@ # See the License for the specific language governing permissions and # limitations under the License. # - -import unittest - import numpy as np import pandas as pd --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org