This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 347c955fe723 [SPARK-46573][K8S] Use `appId` instead of `conf.appId` in 
`LoggingPodStatusWatcherImpl`
347c955fe723 is described below

commit 347c955fe7231eb2912c6678ea7769024f6dc5df
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Wed Jan 3 01:00:22 2024 -0800

    [SPARK-46573][K8S] Use `appId` instead of `conf.appId` in 
`LoggingPodStatusWatcherImpl`
    
    ### What changes were proposed in this pull request?
    This PR replaces the call to `conf.appId` with direct use of `appId` in 
`LoggingPodStatusWatcherImpl`, as it is already defined in 
`LoggingPodStatusWatcherImpl`:
    
    
https://github.com/apache/spark/blob/b74b1592c9ec07b3d29b6d4d900b1d3ba1417cd1/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala#L42
    
    ### Why are the changes needed?
    Should use the already defined `val appId`
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Pass GitHub Actions
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #44569 from LuciferYang/SPARK-46573.
    
    Authored-by: yangjie01 <yangji...@baidu.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
 
b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
index bc8b023b5ecd..3227a72a8371 100644
--- 
a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
+++ 
b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
@@ -96,7 +96,7 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf: 
KubernetesDriverConf)
   }
 
   override def watchOrStop(sId: String): Boolean = {
-    logInfo(s"Waiting for application ${conf.appName} with application ID 
${conf.appId} " +
+    logInfo(s"Waiting for application ${conf.appName} with application ID 
$appId " +
       s"and submission ID $sId to finish...")
     val interval = conf.get(REPORT_INTERVAL)
     synchronized {
@@ -110,7 +110,7 @@ private[k8s] class LoggingPodStatusWatcherImpl(conf: 
KubernetesDriverConf)
       logInfo(
         pod.map { p => s"Container final 
statuses:\n\n${containersDescription(p)}" }
           .getOrElse("No containers were found in the driver pod."))
-      logInfo(s"Application ${conf.appName} with application ID ${conf.appId} 
" +
+      logInfo(s"Application ${conf.appName} with application ID $appId " +
         s"and submission ID $sId finished")
     }
     podCompleted


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to