This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 7f6a1399a56b [SPARK-48098][INFRA] Enable `NOLINT_ON_COMPILE` for all
except `lint` job
7f6a1399a56b is described below
commit 7f6a1399a56b07fa253a85dac757fdd788285274
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Thu May 2 19:26:13 2024 -0700
[SPARK-48098][INFRA] Enable `NOLINT_ON_COMPILE` for all except `lint` job
### What changes were proposed in this pull request?
This PR aims to enable `NOLINT_ON_COMPILE` for all except `lint` job.
### Why are the changes needed?
This will reduce the redundant CPU cycle and GitHub action usage.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #46346 from dongjoon-hyun/SPARK-48098.
Lead-authored-by: Dongjoon Hyun <dh...@apple.com>
Co-authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.github/workflows/build_and_test.yml | 2 ++
project/SparkBuild.scala | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index 92fda7adeb33..3f5a8087885e 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -193,6 +193,7 @@ jobs:
HIVE_PROFILE: ${{ matrix.hive }}
GITHUB_PREV_SHA: ${{ github.event.before }}
SPARK_LOCAL_IP: localhost
+ NOLINT_ON_COMPILE: true
SKIP_UNIDOC: true
SKIP_MIMA: true
SKIP_PACKAGING: true
@@ -606,6 +607,7 @@ jobs:
env:
LC_ALL: C.UTF-8
LANG: C.UTF-8
+ NOLINT_ON_COMPILE: false
PYSPARK_DRIVER_PYTHON: python3.9
PYSPARK_PYTHON: python3.9
GITHUB_PREV_SHA: ${{ github.event.before }}
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 9d2ee6077d11..5bb7745d77bf 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -255,9 +255,11 @@ object SparkBuild extends PomBuild {
}
)
+ val noLintOnCompile = sys.env.contains("NOLINT_ON_COMPILE") &&
+ !sys.env.get("NOLINT_ON_COMPILE").contains("false")
lazy val sharedSettings = sparkGenjavadocSettings ++
compilerWarningSettings ++
- (if (sys.env.contains("NOLINT_ON_COMPILE")) Nil else enableScalaStyle)
++ Seq(
+ (if (noLintOnCompile) Nil else enableScalaStyle) ++ Seq(
(Compile / exportJars) := true,
(Test / exportJars) := false,
javaHome := sys.env.get("JAVA_HOME")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
