This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch branch-3.5 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push: new 1735d7d3fd66 [SPARK-48086][PYTHON][TESTS][3.5] Remove obsolete comment 1735d7d3fd66 is described below commit 1735d7d3fd660560e15457793ccd9b758bb360f8 Author: Hyukjin Kwon <gurwls...@apache.org> AuthorDate: Tue May 7 18:50:47 2024 +0900 [SPARK-48086][PYTHON][TESTS][3.5] Remove obsolete comment ### What changes were proposed in this pull request? This PR proposes to remove those comments for skipped tests related to different Arrow version in JVM. ### Why are the changes needed? Arrow version incompatibility is something we cannot avoid. We should just skip those tests for now. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Linters. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46431 from HyukjinKwon/SPARK-48086. Authored-by: Hyukjin Kwon <gurwls...@apache.org> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- python/pyspark/sql/tests/connect/test_parity_pandas_udf_scalar.py | 1 - python/pyspark/sql/tests/pandas/test_pandas_udf.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/python/pyspark/sql/tests/connect/test_parity_pandas_udf_scalar.py b/python/pyspark/sql/tests/connect/test_parity_pandas_udf_scalar.py index 960f7f11e873..a508fe1059ed 100644 --- a/python/pyspark/sql/tests/connect/test_parity_pandas_udf_scalar.py +++ b/python/pyspark/sql/tests/connect/test_parity_pandas_udf_scalar.py @@ -32,7 +32,6 @@ class PandasUDFScalarParityTests(ScalarPandasUDFTestsMixin, ReusedConnectTestCas def test_vectorized_udf_struct_with_empty_partition(self): super().test_vectorized_udf_struct_with_empty_partition() - # TODO(SPARK-48086): Reenable this test case @unittest.skipIf( "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Failed with different Client <> Server" ) diff --git a/python/pyspark/sql/tests/pandas/test_pandas_udf.py b/python/pyspark/sql/tests/pandas/test_pandas_udf.py index 4673375ccf69..b54e5608f3d0 100644 --- a/python/pyspark/sql/tests/pandas/test_pandas_udf.py +++ b/python/pyspark/sql/tests/pandas/test_pandas_udf.py @@ -262,7 +262,6 @@ class PandasUDFTestsMixin: .collect, ) - # TODO(SPARK-48086): Reenable this test case @unittest.skipIf( "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Failed with different Client <> Server" ) @@ -289,7 +288,6 @@ class PandasUDFTestsMixin: with self.sql_conf({"spark.sql.execution.pandas.convertToArrowArraySafely": False}): df.select(["A"]).withColumn("udf", udf("A")).collect() - # TODO(SPARK-48086): Reenable this test case @unittest.skipIf( "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "Failed with different Client <> Server" ) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org