(spark-connect-go) branch master updated: [SPARK-48754] Address comments (#31)

[ruifengz]

This is an automated email from the ASF dual-hosted git repository.

ruifengz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark-connect-go.git


The following commit(s) were added to refs/heads/master by this push:
     new e0cde67  [SPARK-48754] Address comments (#31)
e0cde67 is described below

commit e0cde671095f499881aff688224910238b860c9f
Author: Martin Grund <martin.gr...@databricks.com>
AuthorDate: Tue Jul 9 04:31:54 2024 +0200

    [SPARK-48754] Address comments (#31)
---
 spark/client/channel/channel.go   | 10 +++++-----
 spark/sql/session/sparksession.go |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/spark/client/channel/channel.go b/spark/client/channel/channel.go
index d0b0394..3d2e246 100644
--- a/spark/client/channel/channel.go
+++ b/spark/client/channel/channel.go
@@ -62,23 +62,23 @@ type BaseBuilder struct {
        headers map[string]string
 }
 
-func (cb BaseBuilder) Host() string {
+func (cb *BaseBuilder) Host() string {
        return cb.host
 }
 
-func (cb BaseBuilder) Port() int {
+func (cb *BaseBuilder) Port() int {
        return cb.port
 }
 
-func (cb BaseBuilder) Token() string {
+func (cb *BaseBuilder) Token() string {
        return cb.token
 }
 
-func (cb BaseBuilder) User() string {
+func (cb *BaseBuilder) User() string {
        return cb.user
 }
 
-func (cb BaseBuilder) Headers() map[string]string {
+func (cb *BaseBuilder) Headers() map[string]string {
        return cb.headers
 }
 
diff --git a/spark/sql/session/sparksession.go 
b/spark/sql/session/sparksession.go
index 8a45fb0..a68b69b 100644
--- a/spark/sql/session/sparksession.go
+++ b/spark/sql/session/sparksession.go
@@ -51,7 +51,7 @@ func (s *SparkSessionBuilder) Remote(connectionString string) 
*SparkSessionBuild
        return s
 }
 
-func (s *SparkSessionBuilder) ChannelBuilder(cb channel.Builder) 
*SparkSessionBuilder {
+func (s *SparkSessionBuilder) WithChannelBuilder(cb channel.Builder) 
*SparkSessionBuilder {
        s.channelBuilder = cb
        return s
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org