This is an automated email from the ASF dual-hosted git repository.
kabhwan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 14e490854f98 [SPARK-49551][SS] Improve RocksDB log for replayChangelog
14e490854f98 is described below
commit 14e490854f98ddb3230f92747cac5eb0361cccfa
Author: Wei Liu <wei....@databricks.com>
AuthorDate: Tue Sep 10 06:21:36 2024 +0900
[SPARK-49551][SS] Improve RocksDB log for replayChangelog
### What changes were proposed in this pull request?
A better log for replayChangelog() in rocksDB.scala. The code change is
straightforward.
### Why are the changes needed?
Log improvement
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #48039 from WweiL/SPARK-49551-rocksdb-log-improve.
Authored-by: Wei Liu <wei....@databricks.com>
Signed-off-by: Jungtaek Lim <kabhwan.opensou...@gmail.com>
---
.../org/apache/spark/sql/execution/streaming/state/RocksDB.scala | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
index 7badc26bf044..5229c6594350 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
@@ -407,10 +407,12 @@ class RocksDB(
* Replay change log from the loaded version to the target version.
*/
private def replayChangelog(endVersion: Long): Unit = {
+ logInfo(log"Replaying changelog from version " +
+ log"${MDC(LogKeys.LOADED_VERSION, loadedVersion)} -> " +
+ log"${MDC(LogKeys.END_VERSION, endVersion)}")
for (v <- loadedVersion + 1 to endVersion) {
- logInfo(log"replaying changelog from version " +
- log"${MDC(LogKeys.LOADED_VERSION, loadedVersion)} -> " +
- log"${MDC(LogKeys.END_VERSION, endVersion)}")
+ logInfo(log"Replaying changelog on version " +
+ log"${MDC(LogKeys.VERSION_NUM, v)}")
var changelogReader: StateStoreChangelogReader = null
try {
changelogReader = fileManager.getChangelogReader(v, useColumnFamilies)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
