This is an automated email from the ASF dual-hosted git repository.
ruifengz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new da2b44931749 [SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation
and its parity test
da2b44931749 is described below
commit da2b4493174971b67dc08a1856620f6b510ceb9e
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Fri May 9 17:45:12 2025 +0800
[SPARK-52053][PYTHON][TESTS] Enable test_job_cancellation and its parity
test
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline
first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Enable test_job_cancellation and its parity test
### Why are the changes needed?
test coverage
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #50845 from zhengruifeng/test_job_cancel.
Authored-by: Ruifeng Zheng <ruife...@apache.org>
Signed-off-by: Ruifeng Zheng <ruife...@apache.org>
---
dev/sparktestsupport/modules.py | 2 ++
python/pyspark/sql/tests/test_job_cancellation.py | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py
index 81f94b1215f7..3134f84a8392 100644
--- a/dev/sparktestsupport/modules.py
+++ b/dev/sparktestsupport/modules.py
@@ -526,6 +526,7 @@ pyspark_sql = Module(
"pyspark.sql.tests.test_functions",
"pyspark.sql.tests.test_group",
"pyspark.sql.tests.test_sql",
+ "pyspark.sql.tests.test_job_cancellation",
"pyspark.sql.tests.arrow.test_arrow",
"pyspark.sql.tests.arrow.test_arrow_map",
"pyspark.sql.tests.arrow.test_arrow_cogrouped_map",
@@ -1053,6 +1054,7 @@ pyspark_connect = Module(
"pyspark.sql.tests.connect.test_parity_functions",
"pyspark.sql.tests.connect.test_parity_group",
"pyspark.sql.tests.connect.test_parity_sql",
+ "pyspark.sql.tests.connect.test_parity_job_cancellation",
"pyspark.sql.tests.connect.test_parity_dataframe",
"pyspark.sql.tests.connect.test_parity_collection",
"pyspark.sql.tests.connect.test_parity_creation",
diff --git a/python/pyspark/sql/tests/test_job_cancellation.py
b/python/pyspark/sql/tests/test_job_cancellation.py
index 3f30f7880889..d6ccb010c60a 100644
--- a/python/pyspark/sql/tests/test_job_cancellation.py
+++ b/python/pyspark/sql/tests/test_job_cancellation.py
@@ -60,9 +60,9 @@ class JobCancellationTestsMixin:
t2.join()
self.assertIsNotNone(output1)
- self.assertEquals(output1, {"tag1"})
+ self.assertEqual(output1, {"tag1"})
self.assertIsNotNone(output2)
- self.assertEquals(output2, {"tag2"})
+ self.assertEqual(output2, {"tag2"})
def check_job_cancellation(
self, setter, canceller, thread_ids, thread_ids_to_cancel,
thread_ids_to_run
@@ -166,6 +166,7 @@ class JobCancellationTestsMixin:
self.assertEqual(first, {"a", "b"})
self.assertEqual(second, {"a", "b", "c"})
+ @unittest.skip("SPARK-52054: Should enable this test")
def test_interrupt_tag(self):
thread_ids = range(4)
self.check_job_cancellation(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
