This is an automated email from the ASF dual-hosted git repository.
uros-b pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 8dd785f98177 [MINOR][DOC] Correct try_to_date docstring versionadded
annotation
8dd785f98177 is described below
commit 8dd785f981770abe9167c202c6c04ef51af3302f
Author: Matthew Hawkes_ONS <[email protected]>
AuthorDate: Thu Jun 25 13:58:51 2026 +0200
[MINOR][DOC] Correct try_to_date docstring versionadded annotation
### What changes were proposed in this pull request?
This PR fixes the `try_to_date` version annotations to reflect the actual
version in which the function became available.
I think this change needs to land in the branch-4.1 branch as well as the
master branch.
### Why are the changes needed?
See https://github.com/apache/spark/issues/56672.
Current docstring says that `pyspark.sql.functions.try_to_date` is "New in
version 4.0.0", but the function is not available in PySpark 4.0.x. The
docstring is misleading. The same is the case for the associated scala and sql
version annotations.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I confirmed the issue by comparing Spark 4.0 and Spark 4.1 source and the
actual runtime behavior of Pyspark.
You can see that try_to_date was introduced in 4.1 by comparing:
-
https://github.com/apache/spark/blob/branch-4.0/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
vs
https://github.com/apache/spark/blob/branch-4.1/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
-
https://github.com/apache/spark/blob/branch-4.0/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
vs
https://github.com/apache/spark/blob/branch-4.1/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #56704 from mh0w/master.
Authored-by: Matthew Hawkes_ONS <[email protected]>
Signed-off-by: Uros Bojanic <[email protected]>
---
python/pyspark/sql/functions/builtin.py | 2 +-
sql/api/src/main/scala/org/apache/spark/sql/functions.scala | 4 ++--
.../apache/spark/sql/catalyst/expressions/datetimeExpressions.scala | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/python/pyspark/sql/functions/builtin.py
b/python/pyspark/sql/functions/builtin.py
index 148e6d5184cf..ab8dcce7a099 100644
--- a/python/pyspark/sql/functions/builtin.py
+++ b/python/pyspark/sql/functions/builtin.py
@@ -11607,7 +11607,7 @@ def try_to_date(col: "ColumnOrName", format:
Optional[str] = None) -> Column:
.. _datetime pattern:
https://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html
- .. versionadded:: 4.0.0
+ .. versionadded:: 4.1.0
Parameters
----------
diff --git a/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
b/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
index 8aea50291cdc..86a495088aad 100644
--- a/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
+++ b/sql/api/src/main/scala/org/apache/spark/sql/functions.scala
@@ -8170,7 +8170,7 @@ object functions {
* value instead of raising an error if date cannot be created.
*
* @group datetime_funcs
- * @since 4.0.0
+ * @since 4.1.0
*/
def try_to_date(e: Column): Column = Column.fn("try_to_date", e)
@@ -8179,7 +8179,7 @@ object functions {
* value instead of raising an error if date cannot be created.
*
* @group datetime_funcs
- * @since 4.0.0
+ * @since 4.1.0
*/
def try_to_date(e: Column, fmt: String): Column = Column.fn("try_to_date",
e, lit(fmt))
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
index 667f79c37288..d14ce21e9a8d 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
@@ -2585,7 +2585,7 @@ case class ParseToDate(
NULL
""",
group = "datetime_funcs",
- since = "4.0.0")
+ since = "4.1.0")
// scalastyle:on line.size.limit
object TryToDateExpressionBuilder extends ExpressionBuilder {
override def build(funcName: String, expressions: Seq[Expression]):
Expression = {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]