This is an automated email from the ASF dual-hosted git repository.
dongjoon-hyun pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new 9c77f3c4a863 [SPARK-58075][INFRA] Add `--rm` to docker run in
`do-release-docker.sh`
9c77f3c4a863 is described below
commit 9c77f3c4a8630c0941d6a5a1a65d19ce25d40142
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Thu Jul 9 15:56:04 2026 -0700
[SPARK-58075][INFRA] Add `--rm` to docker run in `do-release-docker.sh`
### What changes were proposed in this pull request?
This PR aims to add the `--rm` flag to the `docker run` invocation in
`dev/create-release/do-release-docker.sh` so that the release container is
removed automatically when it exits.
### Why are the changes needed?
The container is started with `--env-file`, which injects secrets such as
`ASF_PASSWORD`, `GPG_PASSPHRASE`, `PYPI_API_TOKEN`, and `ASF_NEXUS_TOKEN`.
Without `--rm`, the stopped container remains on the host and the secrets can
be read in plain text via `docker inspect`.
This is safe because nothing references the container after it exits, and
all outputs are written to the host via the `$WORKDIR` volume mount.
### Does this PR introduce _any_ user-facing change?
No. This is a release script which is used by release managers.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5
Closes #57171 from dongjoon-hyun/SPARK-58075.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 0ae5d8664eb37e5127ad1ccf3266ec8e7eb3dddc)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
dev/create-release/do-release-docker.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev/create-release/do-release-docker.sh
b/dev/create-release/do-release-docker.sh
index e231d7a48eec..d0b4ada85659 100755
--- a/dev/create-release/do-release-docker.sh
+++ b/dev/create-release/do-release-docker.sh
@@ -173,7 +173,7 @@ if [ -n "$JAVA" ]; then
fi
echo "Building $RELEASE_TAG; output will be at $WORKDIR/output"
-docker run $([ -z "$GITHUB_ACTIONS" ] && echo "-ti") \
+docker run --rm $([ -z "$GITHUB_ACTIONS" ] && echo "-ti") \
--env-file "$ENVFILE" \
--volume "$WORKDIR:/opt/spark-rm" \
$JAVA_VOL \
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
