[ 
https://issues.apache.org/jira/browse/STANBOL-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753558#comment-13753558
 ] 

Rupert Westenthaler commented on STANBOL-1142:
----------------------------------------------

Hi Sebasitan,

Thank you for this patch. Separating API and implementation should also allow 
to have different implementations (e.g. to use different classifiers).

Had a first look at the patch and he looks good. Will make some more checks and 
commit it to trunk if I do not find any issues.
                
> Topic Classifier: API and Service Implementation should be in separate 
> packages
> -------------------------------------------------------------------------------
>
>                 Key: STANBOL-1142
>                 URL: https://issues.apache.org/jira/browse/STANBOL-1142
>             Project: Stanbol
>          Issue Type: Bug
>          Components: Enhancer
>            Reporter: Sebastian Schaffert
>            Assignee: Rupert Westenthaler
>         Attachments: topic-classifier_API_changes.patch
>
>
> The Topic Classifier Enhancement Engine and Training Set are currently 
> implementing services in the same package where they define their API 
> interfaces. This causes problems when trying to offer the API to services 
> outside the OSGi environment. It would be cleaner to separate the API and 
> implementation into at least different packages or even different modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to