[
https://issues.apache.org/jira/browse/STANBOL-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851514#comment-13851514
]
Rupert Westenthaler commented on STANBOL-1132:
----------------------------------------------
Hi Cristian,
Applied the fixed patch to trunk and merged it back to the 0.12 branch.
Some Notes:
I had to replace the equals implementation of DependencyRelation, because of
several issues: (1) the call to super.equals is a very bad thing, because it
checks for instance equality (2) possibility of NPE in equals checks. I
replaced your version of hashCode and equals with the IDE generated versions.
While fixing the equals method I noticed that the NLP features you added do not
validate parsed parameters. Is is intended that users can parse NULL for all
the defined arguments? If not you should validate those and throw
IllegalArgumentExceptions. This could also allow to write simpler hashcode and
equals methods as one would not check for NULL values.
> Add co-reference resolution and dependency tree support in the Stanbol NLP
> processing API
> -----------------------------------------------------------------------------------------
>
> Key: STANBOL-1132
> URL: https://issues.apache.org/jira/browse/STANBOL-1132
> Project: Stanbol
> Issue Type: New Feature
> Components: Enhancement Engines
> Reporter: Cristian Petroaca
> Assignee: Rupert Westenthaler
> Labels: co-reference, dependency-tree, nlp
> Attachments: coref_dependency_tree_datamodel.patch,
> coref_dependency_tree_datamodel_vers_2.patch,
> coref_dependency_tree_vers_3.patch, coref_dependency_tree_vers_3_fixed.patch
>
>
> Extend the Stanbol NLP Processing API with annotations for co-reference
> resolution and dependency trees.
> Also, add support for JSON Serialisation/Parsing for the co-reference and
> dependency tree annotations so that the RESTful NLP Analysis Service can
> provide co-reference information.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
