Repository: storm
Updated Branches:
  refs/heads/1.x-branch faa312385 -> 5021708fc


Fixed help message for set_log_level command

The help message didn't mention that topology-name was a required parameter, 
thus giving the following error when not passing it:

```
Exception in thread "main" java.lang.IllegalArgumentException: No matching 
field found: IllegalArgumentException for class java.lang.String
        at clojure.lang.Reflector.getInstanceField(Reflector.java:271)
        at clojure.lang.Reflector.invokeNoArgInstanceMember(Reflector.java:315)
        at 
org.apache.storm.command.set_log_level$get_storm_id.invoke(set_log_level.clj:31)
        at 
org.apache.storm.command.set_log_level$_main.doInvoke(set_log_level.clj:75)
        at clojure.lang.RestFn.applyTo(RestFn.java:137)
        at org.apache.storm.command.set_log_level.main(Unknown Source)
```

Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/cb17e79f
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/cb17e79f
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/cb17e79f

Branch: refs/heads/1.x-branch
Commit: cb17e79fa3dc72ffcbbb1e82e358eaaf2199b52d
Parents: faa3123
Author: falmp <[email protected]>
Authored: Sun Jun 5 21:56:02 2016 -0300
Committer: Sriharsha Chintalapani <[email protected]>
Committed: Tue Jun 7 20:04:29 2016 -0700

----------------------------------------------------------------------
 bin/storm.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/cb17e79f/bin/storm.py
----------------------------------------------------------------------
diff --git a/bin/storm.py b/bin/storm.py
index a990de7..74e0c2d 100755
--- a/bin/storm.py
+++ b/bin/storm.py
@@ -256,7 +256,7 @@ def jar(jarfile, klass, *args):
             jvmopts=JAR_JVM_OPTS + ["-Dstorm.jar=" + jarfile])
 
 def sql(sql_file, topology_name):
-    """Syntax: [storm sql sql-file topology]
+    """Syntax: [storm sql sql-file topology-name]
 
     Compiles the SQL statements into a Trident topology and submits it to 
Storm.
     """
@@ -360,26 +360,26 @@ def set_log_level(*args):
     """
     Dynamically change topology log levels
 
-    Syntax: [storm set_log_level -l [logger name]=[log level][:optional 
timeout] -r [logger name]
+    Syntax: [storm set_log_level -l [logger name]=[log level][:optional 
timeout] -r [logger name] topology-name]
     where log level is one of:
         ALL, TRACE, DEBUG, INFO, WARN, ERROR, FATAL, OFF
     and timeout is integer seconds.
 
     e.g.
-        ./bin/storm set_log_level -l ROOT=DEBUG:30
+        ./bin/storm set_log_level -l ROOT=DEBUG:30 topology-name
 
         Set the root logger's level to DEBUG for 30 seconds
 
-        ./bin/storm set_log_level -l com.myapp=WARN
+        ./bin/storm set_log_level -l com.myapp=WARN topology-name
 
         Set the com.myapp logger's level to WARN for 30 seconds
 
-        ./bin/storm set_log_level -l com.myapp=WARN -l 
com.myOtherLogger=ERROR:123
+        ./bin/storm set_log_level -l com.myapp=WARN -l 
com.myOtherLogger=ERROR:123 topology-name
 
         Set the com.myapp logger's level to WARN indifinitely, and 
com.myOtherLogger
         to ERROR for 123 seconds
 
-        ./bin/storm set_log_level -r com.myOtherLogger
+        ./bin/storm set_log_level -r com.myOtherLogger topology-name
 
         Clears settings, resetting back to the original level
     """

Reply via email to