This is an automated email from the ASF dual-hosted git repository.

ethanli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/storm.git


The following commit(s) were added to refs/heads/master by this push:
     new bd4ba78  [STORM-3568] prevent user from changing log level with empty 
logger name from topo UI
     new bec8b19  Merge pull request #3196 from RuiLi8080/STORM-3568
bd4ba78 is described below

commit bd4ba786ebd5964f4624abfde894e10297fb711a
Author: Rui Li <[email protected]>
AuthorDate: Fri Jan 17 15:34:10 2020 -0600

    [STORM-3568] prevent user from changing log level with empty logger name 
from topo UI
---
 .../src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git 
a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html 
b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
index 0dda533..59c7c52 100644
--- 
a/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
+++ 
b/storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/topology.html
@@ -142,6 +142,10 @@ function sendLoggerLevel(id){
             return;
         }
     }
+    if (!loggerName) {
+        alert ("Logger name must be provided. Use \"ROOT\" if you want to 
change current default log behavior.");
+        return;
+    }
     var data = {};
     var loggerSetting;
 

Reply via email to