This is an automated email from the ASF dual-hosted git repository. rzo1 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git
commit 911afe2c0db2dbbaf1aabf5842abebe5931d06e6 Author: Richard Zowalla <[email protected]> AuthorDate: Fri Aug 25 09:35:08 2023 +0200 STORM-3937 - Fix errors/warnings found while generating javadoc in storm-starter --- .../src/jvm/org/apache/storm/starter/SlidingWindowTopology.java | 4 ++-- .../src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java | 2 +- .../src/jvm/org/apache/storm/starter/tools/SlidingWindowCounter.java | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/storm-starter/src/jvm/org/apache/storm/starter/SlidingWindowTopology.java b/examples/storm-starter/src/jvm/org/apache/storm/starter/SlidingWindowTopology.java index a75f9995c..fda309df7 100644 --- a/examples/storm-starter/src/jvm/org/apache/storm/starter/SlidingWindowTopology.java +++ b/examples/storm-starter/src/jvm/org/apache/storm/starter/SlidingWindowTopology.java @@ -58,8 +58,8 @@ public class SlidingWindowTopology { StormSubmitter.submitTopologyWithProgressBar(topoName, conf, builder.createTopology()); } - /* - * Computes tumbling window average + /** + * Computes tumbling window average. */ private static class TumblingWindowAvgBolt extends BaseWindowedBolt { private OutputCollector collector; diff --git a/examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java b/examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java index e37e66658..f3e8a5ac5 100644 --- a/examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java +++ b/examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java @@ -25,7 +25,7 @@ import org.apache.storm.streams.windowing.TumblingWindows; import org.apache.storm.topology.base.BaseWindowedBolt.Count; /** - * An example that illustrates the usage of typed tuples (TupleN<..>) and {@link TupleValueMappers}. + * An example that illustrates the usage of typed tuples (TupleN<..>) and {@link TupleValueMappers}. */ public class TypedTupleExample { diff --git a/examples/storm-starter/src/jvm/org/apache/storm/starter/tools/SlidingWindowCounter.java b/examples/storm-starter/src/jvm/org/apache/storm/starter/tools/SlidingWindowCounter.java index 4ab8488d9..e454ae8d4 100644 --- a/examples/storm-starter/src/jvm/org/apache/storm/starter/tools/SlidingWindowCounter.java +++ b/examples/storm-starter/src/jvm/org/apache/storm/starter/tools/SlidingWindowCounter.java @@ -12,6 +12,8 @@ package org.apache.storm.starter.tools; +import org.apache.storm.starter.bolt.RollingCountBolt; + import java.io.Serializable; import java.util.Map; @@ -19,7 +21,7 @@ import java.util.Map; * This class counts objects in a sliding window fashion. * <p/> * It is designed 1) to give multiple "producer" threads write access to the counter, i.e. being able to increment - * counts of objects, and 2) to give a single "consumer" thread (e.g. {@link PeriodicSlidingWindowCounter}) read access + * counts of objects, and 2) to give a single "consumer" thread (e.g. {@link RollingCountBolt}) read access * to the counter. Whenever the consumer thread performs a read operation, this class will advance the head slot of the * sliding window counter. This means that the consumer thread indirectly controls where writes of the producer threads * will go to. Also, by itself this class will not advance the head slot.
