This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a commit to branch 
3116-refactor-staticruntimeresolvabletreeinput-into-smaller-subcomponents
in repository https://gitbox.apache.org/repos/asf/streampipes.git


The following commit(s) were added to 
refs/heads/3116-refactor-staticruntimeresolvabletreeinput-into-smaller-subcomponents
 by this push:
     new 9ef48df908 refactor(#3116): Add component for node details
9ef48df908 is described below

commit 9ef48df908c496cefcdf46f75459e90604b5f7f0
Author: Philipp Zehnder <[email protected]>
AuthorDate: Mon Aug 12 11:01:39 2024 +0200

    refactor(#3116): Add component for node details
---
 ui/src/app/core-ui/core-ui.module.ts               |  2 ++
 ...ic-runtime-resolvable-tree-input.component.html | 33 ++++++++--------------
 ...atic-runtime-resolvable-tree-input.component.ts |  1 -
 .../static-tree-input-node-details.component.html  | 12 ++++++++
 .../static-tree-input-node-details.component.ts    | 11 ++++++++
 5 files changed, 37 insertions(+), 22 deletions(-)

diff --git a/ui/src/app/core-ui/core-ui.module.ts 
b/ui/src/app/core-ui/core-ui.module.ts
index ce16cf73c1..8b589c4b18 100644
--- a/ui/src/app/core-ui/core-ui.module.ts
+++ b/ui/src/app/core-ui/core-ui.module.ts
@@ -112,6 +112,7 @@ import { PipelineOperationStatusComponent } from 
'./pipeline/pipeline-operation-
 import { StaticTreeInputButtonMenuComponent } from 
'./static-properties/static-runtime-resolvable-tree-input/static-tree-input-button-menu/static-tree-input-button-menu.component';
 import { StaticTreeInputSelectedNodesComponent } from 
'./static-properties/static-runtime-resolvable-tree-input/static-tree-input-selected-nodes/static-tree-input-selected-nodes.component';
 import { StaticTreeInputBrowseNodesComponent } from 
'./static-properties/static-runtime-resolvable-tree-input/static-tree-input-browse-nodes/static-tree-input-browse-nodes.component';
+import { StaticTreeInputNodeDetailsComponent } from 
'./static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component';
 
 @NgModule({
     imports: [
@@ -192,6 +193,7 @@ import { StaticTreeInputBrowseNodesComponent } from 
'./static-properties/static-
         StaticRuntimeResolvableOneOfInputComponent,
         StaticRuntimeResolvableTreeInputComponent,
         StaticTreeInputBrowseNodesComponent,
+        StaticTreeInputNodeDetailsComponent,
         StaticSlideToggleComponent,
         ErrorHintComponent,
         AddToCollectionComponent,
diff --git 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.html
 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.html
index dfda968073..bcb41d33a8 100644
--- 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.html
+++ 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.html
@@ -40,29 +40,20 @@
             </sp-static-tree-input-browse-nodes>
         </div>
         <div fxFlex="40" class="tree-input-section" fxLayout="column">
-            <div class="tree-input-header" fxLayoutAlign="start center">
-                <b>Node Details</b>
-            </div>
-            <div
-                class="node-metadata"
-                *ngFor="let metadata of nodeDetails?.nodeMetadata | keyvalue"
-                fxLayout="row"
-                [attr.data-cy]="'node-details-metadata-row-' + metadata.key"
+            <sp-static-tree-input-node-details
+                [nodeMetadata]="nodeDetails?.nodeMetadata"
             >
-                <div fxFlex="30">{{ metadata.key }}</div>
-                <div fxFlex="70">{{ metadata.value }}</div>
-            </div>
+            </sp-static-tree-input-node-details>
         </div>
 
-        <sp-static-tree-input-selected-nodes
-            class="tree-input-section"
-            fxLayout="column"
-            fxFlex="30"
-            [selectedNodesInternalNames]="
-                staticProperty.selectedNodesInternalNames
-            "
-            (removeSelectedNode)="removeSelectedNode($event)"
-        >
-        </sp-static-tree-input-selected-nodes>
+        <div class="tree-input-section" fxLayout="column" fxFlex="30">
+            <sp-static-tree-input-selected-nodes
+                [selectedNodesInternalNames]="
+                    staticProperty.selectedNodesInternalNames
+                "
+                (removeSelectedNode)="removeSelectedNode($event)"
+            >
+            </sp-static-tree-input-selected-nodes>
+        </div>
     </div>
 </div>
diff --git 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.ts
 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.ts
index caf6937331..32f77cfb1a 100644
--- 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.ts
+++ 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-runtime-resolvable-tree-input.component.ts
@@ -37,7 +37,6 @@ export class StaticRuntimeResolvableTreeInputComponent
     extends 
BaseRuntimeResolvableInput<RuntimeResolvableTreeInputStaticProperty>
     implements OnInit
 {
-    // selectedNodeMetadata: Record<string, string>;
     nodeDetails: TreeInputNode;
 
     @ViewChild('staticTreeInputBrowseNodesComponent')
diff --git 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.html
 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.html
new file mode 100644
index 0000000000..583c7463b8
--- /dev/null
+++ 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.html
@@ -0,0 +1,12 @@
+<div class="tree-input-header" fxLayoutAlign="start center">
+    <b>Node Details</b>
+</div>
+<div
+    class="node-metadata"
+    *ngFor="let metadata of nodeMetadata | keyvalue"
+    fxLayout="row"
+    [attr.data-cy]="'node-details-metadata-row-' + metadata.key"
+>
+    <div fxFlex="30">{{ metadata.key }}</div>
+    <div fxFlex="70">{{ metadata.value }}</div>
+</div>
diff --git 
a/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.ts
 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.ts
new file mode 100644
index 0000000000..238c85e791
--- /dev/null
+++ 
b/ui/src/app/core-ui/static-properties/static-runtime-resolvable-tree-input/static-tree-input-node-details/static-tree-input-node-details.component.ts
@@ -0,0 +1,11 @@
+import { Component, Input } from '@angular/core';
+
+@Component({
+    selector: 'sp-static-tree-input-node-details',
+    templateUrl: './static-tree-input-node-details.component.html',
+    styleUrl: '../static-runtime-resolvable-tree-input.component.scss',
+})
+export class StaticTreeInputNodeDetailsComponent {
+    @Input()
+    nodeMetadata: { [index: string]: any };
+}

Reply via email to