Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/289#discussion_r82084338
  
    --- Diff: 
streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java
 ---
    @@ -18,22 +18,39 @@
     
     package org.apache.streams.twitter.provider;
     
    +import com.fasterxml.jackson.core.JsonProcessingException;
    +import com.fasterxml.jackson.databind.ObjectMapper;
     import com.google.common.base.Preconditions;
     import com.google.common.collect.Lists;
     import com.google.common.collect.Queues;
    +import com.google.common.util.concurrent.Uninterruptibles;
    +import com.typesafe.config.Config;
    +import com.typesafe.config.ConfigFactory;
    +import com.typesafe.config.ConfigParseOptions;
     import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.config.ComponentConfigurator;
    +import org.apache.streams.config.StreamsConfiguration;
    +import org.apache.streams.config.StreamsConfigurator;
     import org.apache.streams.core.DatumStatusCounter;
     import org.apache.streams.core.StreamsDatum;
     import org.apache.streams.core.StreamsProvider;
     import org.apache.streams.core.StreamsResultSet;
    +import org.apache.streams.jackson.StreamsJacksonMapper;
     import org.apache.streams.twitter.TwitterUserInformationConfiguration;
    +import org.apache.streams.twitter.converter.TwitterDateTimeFormat;
    +import org.apache.streams.twitter.pojo.Tweet;
     import org.apache.streams.util.ComponentUtils;
     import org.joda.time.DateTime;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     import twitter4j.*;
    --- End diff --
    
    could u please avoid import *, most apache projects call out the full import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to