Author: husted
Date: Fri Sep 22 14:10:39 2006
New Revision: 449089
URL: http://svn.apache.org/viewvc?view=rev&rev=449089
Log:
OVR-16 Minor fixes to placate Resharper 2.
Modified:
struts/sandbox/trunk/overdrive/Nexus/Core/RequestContext.cs
struts/sandbox/trunk/overdrive/Nexus/Core/Validators/EntryListProcessor.cs
struts/sandbox/trunk/overdrive/Nexus/Core/Validators/ProcessorCommand.cs
Modified: struts/sandbox/trunk/overdrive/Nexus/Core/RequestContext.cs
URL:
http://svn.apache.org/viewvc/struts/sandbox/trunk/overdrive/Nexus/Core/RequestContext.cs?view=diff&rev=449089&r1=449088&r2=449089
==============================================================================
--- struts/sandbox/trunk/overdrive/Nexus/Core/RequestContext.cs (original)
+++ struts/sandbox/trunk/overdrive/Nexus/Core/RequestContext.cs Fri Sep 22
14:10:39 2006
@@ -60,7 +60,7 @@
{
foreach (DictionaryEntry entry in entries)
{
- Add(entry.Key, entry.Value);
+ base.Add(entry.Key, entry.Value);
}
}
@@ -96,7 +96,7 @@
set
{
this[UserProfile.USER_PROFILE] = value;
- IProfile profile = value as IProfile;
+ IProfile profile = value;
if (null != profile)
this[UserProfile.USER_ID] =
profile.UserId;
}
@@ -203,7 +203,7 @@
public bool HasAlerts
{
- get { return this.ContainsKey(Tokens.Alerts); }
+ get { return ContainsKey(Tokens.Alerts); }
}
public Exception Fault
@@ -211,7 +211,7 @@
get { return this[Tokens.Fault] as Exception; }
set
{
- Exception e = value as Exception;
+ Exception e = value;
this[Tokens.Fault] = e;
AddAlert(e.Message);
}
@@ -219,7 +219,7 @@
public bool HasFault
{
- get { return this.ContainsKey(Tokens.Fault); }
+ get { return ContainsKey(Tokens.Fault); }
}
public bool IsNominal
@@ -245,7 +245,7 @@
public bool HasHints
{
- get { return this.ContainsKey(Tokens.Hints); }
+ get { return ContainsKey(Tokens.Hints); }
}
}
Modified:
struts/sandbox/trunk/overdrive/Nexus/Core/Validators/EntryListProcessor.cs
URL:
http://svn.apache.org/viewvc/struts/sandbox/trunk/overdrive/Nexus/Core/Validators/EntryListProcessor.cs?view=diff&rev=449089&r1=449088&r2=449089
==============================================================================
--- struts/sandbox/trunk/overdrive/Nexus/Core/Validators/EntryListProcessor.cs
(original)
+++ struts/sandbox/trunk/overdrive/Nexus/Core/Validators/EntryListProcessor.cs
Fri Sep 22 14:10:39 2006
@@ -35,8 +35,8 @@
ICollection keys = row.Keys;
foreach (string key in keys)
{
- // IProcessorContext _context = new
ProcessorContext(key, context);
- // formatter.ExecuteProcess(_context);
+ IProcessorContext _context = new
ProcessorContext(key, context);
+ formatter.ExecuteProcess(_context);
}
target.AddEntry(context.Criteria);
}
Modified:
struts/sandbox/trunk/overdrive/Nexus/Core/Validators/ProcessorCommand.cs
URL:
http://svn.apache.org/viewvc/struts/sandbox/trunk/overdrive/Nexus/Core/Validators/ProcessorCommand.cs?view=diff&rev=449089&r1=449088&r2=449089
==============================================================================
--- struts/sandbox/trunk/overdrive/Nexus/Core/Validators/ProcessorCommand.cs
(original)
+++ struts/sandbox/trunk/overdrive/Nexus/Core/Validators/ProcessorCommand.cs
Fri Sep 22 14:10:39 2006
@@ -49,7 +49,7 @@
public virtual bool ExecuteConvert(IProcessorContext context)
{
- bool okay = false;
+ bool okay;
string id = context.FieldKey;
IFieldTable table = context.FieldTable;
IFieldContext fieldContext = table.GetFieldContext(id);
// enforces Strict
@@ -102,7 +102,7 @@
if (source == null)
context.Target = null;
else okay = FormatOutput(context);
- return true;
+ return okay;
}
IProcessor processor = fieldContext.Processor;
