This is an automated email from the ASF dual-hosted git repository. lukaszlenart pushed a commit to branch build/intellij-2026-3 in repository https://gitbox.apache.org/repos/asf/struts-intellij-plugin.git
commit 6f964b69c73686c67ec6a257810b3783e09c3c42 Author: Lukasz Lenart <[email protected]> AuthorDate: Fri Nov 13 08:11:18 2026 +0100 docs: add JSP module step to 2026.3 plan Co-authored-by: Cursor <[email protected]> --- .../2026-11-13-intellij-2026-3-compatibility.md | 63 +++++++++++++++++++++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/docs/superpowers/plans/2026-11-13-intellij-2026-3-compatibility.md b/docs/superpowers/plans/2026-11-13-intellij-2026-3-compatibility.md index a12aff0..1f95065 100644 --- a/docs/superpowers/plans/2026-11-13-intellij-2026-3-compatibility.md +++ b/docs/superpowers/plans/2026-11-13-intellij-2026-3-compatibility.md @@ -170,9 +170,70 @@ Keep the first matching line in a local note for the pull request body (Task 5). --- +### Task 2a: Replace the removed JSP bundled plugin (commit 1b) + +**Why this task exists:** Task 2 found that 2026.3 no longer ships `com.intellij.jsp` as a bundled plugin. `./gradlew compileJava` fails at dependency resolution with `Could not find bundled plugin with ID: 'com.intellij.jsp'` (`build.gradle.kts:58`), before any Java compiles. `printBundledPlugins` has no JSP plugin, and `printBundledModules` lists `intellij.jsp`, `intellij.jsp.base`, and `intellij.jsp.spi`. The XML gate in Task 2 cannot run until this resolves. + +**Files:** +- Modify: `build.gradle.kts` (the `bundledPlugin("com.intellij.jsp")` line) +- Modify: `src/main/resources/META-INF/plugin.xml` (the `<plugin id="com.intellij.jsp"/>` line) + +**Interfaces:** +- Consumes: the commit 1 tree from Task 1 (`014bd2f`). +- Produces: a build that resolves on 2026.3 past dependency resolution, so Task 2's XML gate can be re-run. + +- [ ] **Step 1: Replace the Gradle dependency** + +In `build.gradle.kts`, replace: + +```kotlin + bundledPlugin("com.intellij.jsp") +``` +with: +```kotlin + bundledModule("intellij.jsp") +``` + +Keep `bundledModule("intellij.javaee.jsp.shared")` unchanged. + +- [ ] **Step 2: Replace the plugin.xml dependency** + +In `src/main/resources/META-INF/plugin.xml`, replace: + +```xml + <plugin id="com.intellij.jsp"/> +``` +with: +```xml + <module name="intellij.jsp"/> +``` + +Keep `<module name="intellij.javaee.jsp.shared"/>` unchanged. + +- [ ] **Step 3: Re-run compilation (this is the XML gate re-run)** + +Run: `./gradlew compileJava 2>&1 | tee .superpowers/sdd/2026-3-compile-2a.log` +Expected: either `BUILD SUCCESSFUL`, or a failure that names an XML type (record it). A failure that is still a dependency-resolution error on another bundled ID is a new break: stop and report it, do not fix it here. + +- [ ] **Step 4: Verify the plugin.xml form with the verifier** + +Run: `./gradlew runPluginVerifier 2>&1 | tee .superpowers/sdd/2026-3-verify-2a.log` +If the verifier reports that `intellij.jsp` is not a known module, or that JSP classes cannot load at runtime, switch Step 2 to `<plugin id="com.intellij.jsp"/>` kept as-is and record the verifier output. Report the decision in the commit body. + +- [ ] **Step 5: Commit** + +```bash +git add build.gradle.kts src/main/resources/META-INF/plugin.xml +git commit -m "build: use IntelliJ 2026.3 JSP bundled module" -m "com.intellij.jsp is no longer a bundled plugin on 2026.3, so compileJava failed during dependency resolution. Depend on the intellij.jsp content module in Gradle and plugin.xml instead." +``` + +Do not change `CHANGELOG.md` in this task. Task 3's changelog bullet covers the platform dependency changes. + +--- + ### Task 3: Declare the XML plugin dependency (commit 2) -Run this task only when Task 2 recorded a missing XML type. +Run this task only when Task 2 recorded a missing XML type. If Task 2a's re-run shows a missing XML type, Task 2's gate result is satisfied and this task runs. **Files:** - Modify: `src/main/resources/META-INF/plugin.xml` (inside `<dependencies>`)
