tangzhankun commented on a change in pull request #320:
URL: https://github.com/apache/submarine/pull/320#discussion_r443308122



##########
File path: dev-support/cicd/HowToRelease.md
##########
@@ -6,20 +6,19 @@ If you have not already done so, generate your PGP key and 
append your [signing
 End users use the KEYS file to validate that releases were done by an Apache 
committer.
 
 ```
-# generate key and upload to the public
+# generate key and send keys to a keyserver
 gpg --gen-key
 gpg --list-sigs <your name>
-gpg --keyserver pgp.mit.edu --send-key <your publish key RSA string like 
B3097AC in the above cmd output>
+gpg --keyserver pgp.mit.edu --send-keys <your publish key RSA string like 
B3097AC in the above cmd output>
 gpg --refresh-keys --keyserver pgp.mit.edu
-# adding your key to submarine KEYS
-gpg --list-sigs <your name> >> ~/key.txt
-gpg --armor --export <your name> >> ~/key.txt
+
+# adding your key to the submarine KEYS
 svn co --depth immediates https://dist.apache.org/repos/dist apache-dist
 cd apache-dist
 svn update --set-depth infinity release/submarine
 cd release/submarine
-echo ~/key.txt >> KEYS
-svn add KEYS
+gpg --fingerprint <your name> >> KEYS

Review comment:
       @jiwq , one question, why change to "fingerprint"?
   
   ```
   $ gpg --list-sigs ztang
   pub   rsa2048 2019-05-29 [SC] [expires: 2021-05-28]
         4B3097ACE9D46117F0C4FC2BF82CBAEEEC87F784
   uid           [ultimate] Zhankun Tang <[email protected]>
   sig 3        F82CBAEEEC87F784 2019-05-29  Zhankun Tang <[email protected]>
   sig          F4313315266526CB 2019-05-29  Sunil Govindan (CODE SIGNING KEY) 
<[email protected]>
   sub   rsa2048 2019-05-29 [E] [expires: 2021-05-28]
   sig          F82CBAEEEC87F784 2019-05-29  Zhankun Tang <[email protected]>
   
   
   
   $ gpg --fingerprint ztang
   pub   rsa2048 2019-05-29 [SC] [expires: 2021-05-28]
         4B30 97AC E9D4 6117 F0C4  FC2B F82C BAEE EC87 F784
   uid           [ultimate] Zhankun Tang <[email protected]>
   sub   rsa2048 2019-05-29 [E] [expires: 2021-05-28]
   ```
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to