lowc1012 commented on a change in pull request #481:
URL: https://github.com/apache/submarine/pull/481#discussion_r548859687
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -254,6 +267,19 @@ public Notebook createNotebook(NotebookSpec spec) throws
SubmarineRuntimeExcepti
Map<String, String> labels = new HashMap<>();
labels.put(NotebookCR.NOTEBOOK_OWNER_SELECTOR_KET,
spec.getMeta().getOwnerId());
notebookCR.getMetadata().setLabels(labels);
+
+ // create persistent volume
+ createPersistentVolume(notebookCR.getMetadata().getName());
+
+ // create persistent volume claim
+ createPersistentVolumeClaim(notebookCR.getMetadata().getNamespace(),
+ notebookCR.getMetadata().getName());
+
+ // bind persistent volume claim
+ V1PersistentVolumeClaimVolumeSource pvc_source = new
V1PersistentVolumeClaimVolumeSource()
Review comment:
Variable name should be in lower camel case.
Please correct the others in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
