[GitHub] [submarine] kevin85421 opened a new pull request #702: SUBMARINE-965. Users should not have the privilege to create experiments in different namespaces

Sun, 08 Aug 2021 10:21:32 -0700 


kevin85421 opened a new pull request #702:
URL: https://github.com/apache/submarine/pull/702


   ### What is this PR for?
   In our multi-tenant architecture, users only can create experiments in their 
namespaces, but the Submarine workbench enables users to specify namespaces.
   ![截圖 2021-08-08 上午10 17 
13](https://user-images.githubusercontent.com/20109646/128638163-c3d30a53-5e21-4460-b2a3-3ded61d49d6e.png)
   
   This patch aims to 
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-965
   
   ### How should this be tested?
   **Test1**
   * Step1: Use submarine-operator to create a submarine service in the 
namespace "submarine-user-test"
   * Step2: Create an experiment, and check whether the experiment is in the 
namespace "submarine-user-test" rather than "default".
   
   <img width="1439" alt="截圖 2021-08-08 下午11 57 35" 
src="https://user-images.githubusercontent.com/20109646/128640083-61ffc46d-fc26-4f22-8769-8202092c6574.png";>
   
   **Test2**
   * Remove the field "namespace" in the Submarine workbench
   
   
   ### Screenshots (if appropriate)
   <img width="1439" alt="截圖 2021-08-08 下午11 57 35" 
src="https://user-images.githubusercontent.com/20109646/128640083-61ffc46d-fc26-4f22-8769-8202092c6574.png";>
   
   <img width="994" alt="截圖 2021-08-09 上午1 19 46" 
src="https://user-images.githubusercontent.com/20109646/128640160-58a94857-346d-4ce9-8d14-97edeb4de26e.png";>
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to