Kenchu123 opened a new pull request #707:
URL: https://github.com/apache/submarine/pull/707


   ### What is this PR for?
   <!-- A few sentences describing the overall goals of the pull request's 
commits.
   First time? Check out the contributing guide - 
https://submarine.apache.org/contribution/contributions.html
   -->
   
   To create persistent volumes, submarine-operator creates persistent volumes 
with different names depending on the namespace (eg. 
`submarine-database-pv–default`)
   
   However, we can use storage class to create persistent volumes dynamically 
and delete them easily.
   
   This will be implemented only on the submarine operator. Besides, only 
minikube support the current storage class provisioner, and volumes can only be 
in the host (nfs not supported).
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   - [x] Add storage class
   - [x] Modify operator to create persistent volume claim with storage class 
name
   - [x] Remove persistent volume creation in operator
   
   ### What is the Jira issue?
   <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
   * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. 
`SUBMARINE-23. PR title`
   -->
   
   https://issues.apache.org/jira/browse/SUBMARINE-975
   
   ### How should this be tested?
   <!--
   * First time? Setup Travis CI as described on 
https://submarine.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
   * Outline any manual steps to test the PR here.
   -->
   
   Follow submarine-operator instructions.
   
   ### Screenshots (if appropriate)
   
   
https://user-images.githubusercontent.com/17617373/129319157-5923ebcf-cdf4-45ae-b18c-e3cc0eb45b16.mov
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to