pingsutw commented on a change in pull request #767:
URL: https://github.com/apache/submarine/pull/767#discussion_r725445727
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -565,6 +584,79 @@ public ServeResponse deleteServe(ServeRequest spec)
}
}
+ public void watchExperiment() throws ApiException{
Review comment:
Could we add a unit test or integration test for it?
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -133,7 +146,13 @@ public void initialize(SubmarineConfiguration conf) {
appsV1Api = new AppsV1Api();
}
- client.setDebugging(true);
+ try {
+ watchExperiment();
+ } catch (Exception e){
+ LOG.error("Experiment watch failed. " + e.getMessage(), e);
+ }
+
+ // client.setDebugging(true);
Review comment:
Remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
