Author: cmpilato
Date: Wed Jun 20 17:22:14 2012
New Revision: 1352215

URL: http://svn.apache.org/viewvc?rev=1352215&view=rev
Log:
* subversion/mod_dav_svn/mirror.c
  (proxy_request_fixup): Add a FIXME comment about possibly not
    including filters when they will later be removed anyway.  Just
    something stsp and I noticed in Berlin.

Modified:
    subversion/trunk/subversion/mod_dav_svn/mirror.c

Modified: subversion/trunk/subversion/mod_dav_svn/mirror.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/mirror.c?rev=1352215&r1=1352214&r2=1352215&view=diff
==============================================================================
--- subversion/trunk/subversion/mod_dav_svn/mirror.c (original)
+++ subversion/trunk/subversion/mod_dav_svn/mirror.c Wed Jun 20 17:22:14 2012
@@ -54,6 +54,16 @@ static void proxy_request_fixup(request_
                                                            (char *)NULL),
                                                r->pool);
     r->handler = "proxy-server";
+
+    /* ### FIXME: Seems we could avoid adding some or all of these
+           filters altogether when the root_dir (that is, the slave's
+           location, relative to the server root) and path portion of
+           the master_uri (the master's location, relative to the
+           server root) are identical, rather than adding them here
+           and then trying to remove them later.  (See the filter
+           removal logic in dav_svn__location_in_filter() and
+           dav_svn__location_body_filter().  -- cmpilato */
+
     ap_add_output_filter("LocationRewrite", NULL, r, r->connection);
     ap_add_output_filter("ReposRewrite", NULL, r, r->connection);
     ap_add_input_filter("IncomingRewrite", NULL, r, r->connection);


Reply via email to