Author: futatuki
Date: Sun Dec 20 05:40:35 2020
New Revision: 1884640

URL: http://svn.apache.org/viewvc?rev=1884640&view=rev
Log:
swig-py: Follow up to r1880967: Fix a comment about the place we raise
Python exception 'exc_ob'.

* subversion/bindings/swig/include/svn_types.swg
  (typemap(out) svn_error_t * SVN_ERR_WITH_ATTRS):
  - Fix comment after the block checking if exc_ob is NULL.
    We raise the exception for exc_ob within the callee function block,
    do not entrust to the caller.
  - Remove trailing spaces on end of lines.

Modified:
    subversion/trunk/subversion/bindings/swig/include/svn_types.swg

Modified: subversion/trunk/subversion/bindings/swig/include/svn_types.swg
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/include/svn_types.swg?rev=1884640&r1=1884639&r2=1884640&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/include/svn_types.swg (original)
+++ subversion/trunk/subversion/bindings/swig/include/svn_types.swg Sun Dec 20 
05:40:35 2020
@@ -439,7 +439,7 @@ svn_ ## TYPE ## _swig_rb_closed(VALUE se
     $result = Py_None;
 }
 
-%typemap(out) svn_error_t * SVN_ERR_WITH_ATTRS (apr_status_t apr_err, 
+%typemap(out) svn_error_t * SVN_ERR_WITH_ATTRS (apr_status_t apr_err,
                                                 PyObject *exc_class,
                                                 PyObject *exc_ob) {
     apr_err = 0;
@@ -451,7 +451,7 @@ svn_ ## TYPE ## _swig_rb_closed(VALUE se
           {
             svn_swig_py_build_svn_exception(&exc_class, &exc_ob, $1);
             if (exc_ob == NULL)
-              { 
+              {
                 /* We couldn't get an exception instance. */
                 if (exc_class != NULL)
                   {
@@ -461,8 +461,8 @@ svn_ ## TYPE ## _swig_rb_closed(VALUE se
                   }
                 SWIG_fail;
               }
-            /* We have an exeception instance, but we don't raise it.
-               Our caller will have to do that. */
+            /* We have an exeception instance, but we don't raise it until
+               typemap(ret) block after typemap(argout) blocks. */
           }
         else
           {


Reply via email to