Dear Daniel,

I've updated the commit message, hope it is better now. Thanks for your
feedback!

/Daniel

(No worries about the wait, my wife keeps reminding me I've got a family to
hang out with)

Den ons 6 jan. 2021 kl 16:45 skrev Daniel Shahaf <d...@daniel.shahaf.name>:

> Good morning Daniel,
>
> dsahlb...@apache.org wrote on Mon, 04 Jan 2021 18:17 +00:00:
> > Author: dsahlberg
> > Date: Mon Jan  4 18:17:01 2021
> > New Revision: 1885120
> >
> > URL: http://svn.apache.org/viewvc?rev=1885120&view=rev
> > Log:
> > * publish/contributing.html:
> >   (#code/Become a committer): Remove links to Fitz' articles altogether
>
> Log messages should answer "Why?", not "What?" (the unidiff itself does
> that), and this one doesn't.  Could you extend it, please?  See r1884997
> for an example.
>
> A pointer to the dev@ thread would be fine, too.  The pointer should be
> long-lived; generally that means it should spell out the message-id.  (As
> to me, usually I either copy the Date/From/To/Cc/Subject/Message-ID
> headers in this order, or give a mail-archives.a.o link, which
> identifies the List-ID and Message-ID.  My email client is set up so
> I can generate either kind of pointer easily.)
>
> Cheers,
>
> Daniel
>
> P.S.  We still owe you an answer on your other thread, I know.  Sorry
>       for the delay.  I've pinged the private@ thread for you.
>
> > Modified:
> >     subversion/site/publish/contributing.html
> >
> > Modified: subversion/site/publish/contributing.html
> > URL:
> >
> http://svn.apache.org/viewvc/subversion/site/publish/contributing.html?rev=1885120&r1=1885119&r2=1885120&view=diff
> >
> ==============================================================================
> > --- subversion/site/publish/contributing.html (original)
> > +++ subversion/site/publish/contributing.html Mon Jan  4 18:17:01 2021
> > @@ -222,11 +222,7 @@
> >         beneficial to the developer community &mdash; where quality
> >         developers are concerned, "the more, the merrier"!  But never
> >         underestimate how valuable this experience can be to you
> > -       personally
> > -       and <a
> > href="
> https://web.archive.org/web/20050803084234/http://onlamp.com/pub/a/onlamp/2005/07/14/osdevelopers.html
> "
> > -       >professionally</a>,
> > -       <a
> > href="
> https://web.archive.org/web/20051214172122/http://onlamp.com/pub/a/onlamp/2005/08/01/opensourcedevelopers.html
> "
> > -       >too</a>.</p>
> > +       personally and professionally.</p>
> >  </li>
> >  </ul>
> >
> >
> >
> >
>

Reply via email to