Author: danielsh Date: Tue Jan 25 11:34:50 2022 New Revision: 1897452 URL: http://svn.apache.org/viewvc?rev=1897452&view=rev Log: svntest: Guard against test-writing bugs, such as the one described in r1897439.
I was going to validate «error_expected» too for being a boolean-esque type (NoneType, bool, or int), but it turns out some tests pass string values into it, and as such would have been broken hard (AssertionError rather than svntest.Failure) by such validation. See [1] for details. [1] https://mail-archives.apache.org/mod_mbox/subversion-dev/202201.mbox/%3C20220125113122.GA26658%40tarpaulin.shahaf.local2%3E * subversion/tests/cmdline/svntest/main.py (run_command_stdin): Smoke test the variadic arguments.--- a/subversion/tests/cmdline/svntest/main.py +++ b/subversion/tests/cmdline/svntest/main.py @@ -616,6 +616,8 @@ start = time.time() + assert all(isinstance(arg, (str, unicode, int)) for arg in varargs) + exit_code, stdout_lines, stderr_lines = spawn_process(command, bufsize, binary_mode, Modified: subversion/trunk/subversion/tests/cmdline/svntest/main.py Modified: subversion/trunk/subversion/tests/cmdline/svntest/main.py URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svntest/main.py?rev=1897452&r1=1897451&r2=1897452&view=diff ============================================================================== --- subversion/trunk/subversion/tests/cmdline/svntest/main.py (original) +++ subversion/trunk/subversion/tests/cmdline/svntest/main.py Tue Jan 25 11:34:50 2022 @@ -616,6 +616,8 @@ def run_command_stdin(command, error_exp start = time.time() + assert all(isinstance(arg, (str, unicode, int)) for arg in varargs) + exit_code, stdout_lines, stderr_lines = spawn_process(command, bufsize, binary_mode,
