Author: gstein
Date: Wed Oct 25 08:28:11 2023
New Revision: 1913315
URL: http://svn.apache.org/viewvc?rev=1913315&view=rev
Log:
simplify dirlist handling; avoid in-place change
Modified:
subversion/trunk/tools/hook-scripts/mailer/mailer.py
Modified: subversion/trunk/tools/hook-scripts/mailer/mailer.py
URL:
http://svn.apache.org/viewvc/subversion/trunk/tools/hook-scripts/mailer/mailer.py?rev=1913315&r1=1913314&r2=1913315&view=diff
==============================================================================
--- subversion/trunk/tools/hook-scripts/mailer/mailer.py (original)
+++ subversion/trunk/tools/hook-scripts/mailer/mailer.py Wed Oct 25 08:28:11
2023
@@ -517,12 +517,11 @@ class Commit(Messenger):
commondir, dirlist = get_commondir(dirlist)
# compose the basic subject line. later, we can prefix it.
- dirlist.sort()
- dirlist = ' '.join(dirlist)
+ dirlist_s = ' '.join(sorted(dirlist))
if commondir:
- self.basic_subject = 'r%d - in %s: %s' % (repos.rev, commondir, dirlist)
+ self.basic_subject = 'r%d - in %s: %s' % (repos.rev, commondir,
dirlist_s)
else:
- self.basic_subject = 'r%d - %s' % (repos.rev, dirlist)
+ self.basic_subject = 'r%d - %s' % (repos.rev, dirlist_s)
def generate(self, output, scratch_pool):
"Generate email for the various groups and option-params."
