Author: futatuki
Date: Sun Jan 14 18:16:09 2024
New Revision: 1915235

URL: http://svn.apache.org/viewvc?rev=1915235&view=rev
Log:
swig-rb: Block SWIG 4.2.0 before building Ruby bindings

SWIG Ruby bindings cannot build with SWIG 4.2.0 because it produces
a broken external runtime code[1]. So we note it is broken and
block users from building swig-rb with it.

[1] https://github.com/swig/swig/issues/2751

* build/ac-macros/swig.m4
  (SVN_FIND_SWIG): Check SWIG 4.2.0 and block it for swig-rb.
* subversion/bindings/swig/INSTALL
  (BUILDING SWIG BINDINGS FOR SVN ON UNIX, Step 1):
   Note that SWIG 4.2.0 is broken for Ruby.

Reported by: @jplesnik on Github,
             jun66j5

Modified:
    subversion/trunk/build/ac-macros/swig.m4
    subversion/trunk/subversion/bindings/swig/INSTALL

Modified: subversion/trunk/build/ac-macros/swig.m4
URL: 
http://svn.apache.org/viewvc/subversion/trunk/build/ac-macros/swig.m4?rev=1915235&r1=1915234&r2=1915235&view=diff
==============================================================================
--- subversion/trunk/build/ac-macros/swig.m4 (original)
+++ subversion/trunk/build/ac-macros/swig.m4 Sun Jan 14 18:16:09 2024
@@ -252,6 +252,10 @@ suitable Ruby interpreter is not found."
       if test "$SWIG" = "none"; then
         AC_MSG_WARN([You specified to build SWIG Ruby bindings, but SWIG is 
not found.])
         SWIG_RB_ERRMSG="SWIG is need to build SWIG Ruby bindings, but it is 
not found."
+      elif test x"$SWIG_VERSION" = x"4""02""000"; then
+        ruby_swig_issue_2751='https://github.com/swig/swig/issues/2751'
+        AC_MSG_WARN([Ruby bindings cannot be built with swig 4.2.0; see 
$ruby_swig_issue_2751])
+        SWIG_RB_ERRMSG="SWIG 4.2.0 was found but it cannot be used for 
building SWIG Ruby bindings."
       else
         if test x"$SWIG_VERSION" = x"3""00""008"; then
           # Use a local variable to escape the '#' sign.

Modified: subversion/trunk/subversion/bindings/swig/INSTALL
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/INSTALL?rev=1915235&r1=1915234&r2=1915235&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/INSTALL (original)
+++ subversion/trunk/subversion/bindings/swig/INSTALL Sun Jan 14 18:16:09 2024
@@ -92,6 +92,9 @@ Step 1: [Optional] Install a suitable ve
         (See https://sourceforge.net/p/swig/news/2016/06/swig-3010-released/)
       - For Perl 5.16 and later, SWIG 2.0.8 or later is required.
       - For Ruby bindings, SWIG 3.0.8 is not supported.
+        (See https://github.com/swig/swig/issues/602)
+      - For Ruby bindings, SWIG 4.2.0 is broken. 
+        (See https://github.com/swig/swig/issues/2751)
 
     * Perhaps your distribution packages a suitable version of SWIG.
       If so, install it and skip to the last bullet point of this


Reply via email to