Author: rinrab
Date: Sun Aug 11 15:08:03 2024
New Revision: 1919813

URL: http://svn.apache.org/viewvc?rev=1919813&view=rev
Log:
On the 'cmake' branch: Fixup Perl flags list before using them.

We are utilizing the additional Perl compile options from the FindPerlLibs
module. However, they are incorrectly separated (they should be represented
as a CMake array, while they are recorded just as a plain string).

CMake provides an out-of-box function that could convert one format to another,
so we could just invoke it to fixup the compile options before usage.

This fix will resolve an issue when compiling the Perl SWIG bindings on Linux
with CMake. The problem was reported and discussed on the dev@ list. The thread
is publicly archived at [1].

* CMakeLists.txt
  (swig.perl): Use the separate_arguments() command to fixup compile options.

[1] https://lists.apache.org/thread/g7w5z12l9dw41lhc25zyqnvr298mcw95

Modified:
    subversion/branches/cmake/CMakeLists.txt

Modified: subversion/branches/cmake/CMakeLists.txt
URL: 
http://svn.apache.org/viewvc/subversion/branches/cmake/CMakeLists.txt?rev=1919813&r1=1919812&r2=1919813&view=diff
==============================================================================
--- subversion/branches/cmake/CMakeLists.txt (original)
+++ subversion/branches/cmake/CMakeLists.txt Sun Aug 11 15:08:03 2024
@@ -288,6 +288,8 @@ if(SVN_ENABLE_SWIG_PERL)
   find_package(Perl REQUIRED)
   find_package(PerlLibs REQUIRED)
 
+  separate_arguments(PERL_EXTRA_C_FLAGS)
+
   add_library(external-perl IMPORTED INTERFACE)
   target_include_directories(external-perl INTERFACE
     ${PERL_INCLUDE_PATH}


Reply via email to