Author: dsahlberg
Date: Sun Sep 8 21:19:51 2024
New Revision: 1920521
URL: http://svn.apache.org/viewvc?rev=1920521&view=rev
Log:
Followup to r1919535.
err was already declared earlier in the same function. In addition the second
declaration was not on the top of the block, violating C90.
This was caught compiling with --enable-maintainer-mode.
We can reuse the existing pointer, since it is only used when an error occurs
and in that case the function immediately return.
* subversion/svnlook/svnlook.c
(sub_main, handling option l): Re-use existing err pointer
Found by: rinrab
Modified:
subversion/trunk/subversion/svnlook/svnlook.c
Modified: subversion/trunk/subversion/svnlook/svnlook.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/svnlook/svnlook.c?rev=1920521&r1=1920520&r2=1920521&view=diff
==============================================================================
--- subversion/trunk/subversion/svnlook/svnlook.c (original)
+++ subversion/trunk/subversion/svnlook/svnlook.c Sun Sep 8 21:19:51 2024
@@ -2584,7 +2584,7 @@ sub_main(int *exit_code, int argc, const
{
const char *utf8_opt_arg;
SVN_ERR(svn_utf_cstring_to_utf8(&utf8_opt_arg, opt_arg, pool));
- svn_error_t *err = svn_cstring_atoi(&opt_state.limit,
utf8_opt_arg);
+ err = svn_cstring_atoi(&opt_state.limit, utf8_opt_arg);
if (err)
{
return svn_error_create(SVN_ERR_CL_ARG_PARSING_ERROR, err ,
