On Thu, Sep 19, 2024 at 2:59 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > > Den ons 18 sep. 2024 kl 18:38 skrev <rin...@apache.org>: >> >> Author: rinrab >> Date: Wed Sep 18 16:38:36 2024 >> New Revision: 1920771 >> >> URL: http://svn.apache.org/viewvc?rev=1920771&view=rev >> Log: >> build: Export some private functions from libraries, to link tools and >> tests which uses them, against shared versions. >> >> Now, the tests can be compiled in shared configuration on Windows with CMake, >> which was impossible before due to not-exported functions from DLLs. >> >> * build.conf >> (libsvn_fs_fs, libsvn_fs_x, libsvn_fs_base, >> libsvn_subr, libsvn_wc): Add private headers to msvc-export to get >> them into .lib file. >> (executables, tests, and tools, which were forced to be static): Allow them >> to be linked against shared libraries. > > > I can't find any remaining use of msvc-force-static. > > Is it needed anymore or should we remove the support completely? It would > affect a comment in build.conf as well as code in build/generator/gen_base.py > (setting msvc_force_static from msvc-force-static) and > build/generator/gen_[cmake|win].py (using msvc_force_static).
Yes, there are no more usages of this option. I have already made a patch where it is removed, but decided to wait a bit and commit it later. -- Timofei Zhakov
