Author: dsahlberg
Date: Tue Feb 25 20:49:54 2025
New Revision: 1924046

URL: http://svn.apache.org/viewvc?rev=1924046&view=rev
Log:
r1845942 added a test of GitHub's SVN bridge. The bridge was sunsetted in
January 2024[1] so the test now fail.

The test was primarily testing GitHub's own SVN implementation (and local 
internet connectivity). Since there are no other (known) 3rd-party server
implementations there is no point in changing the URL.

* subversion/tests/cmdline/dav_tests.py
  (connect_to_github_server): Remove test case.

Discussed on dev@: [2]


[1] 
https://github.blog/news-insights/product-news/sunsetting-subversion-support/
[2] https://lists.apache.org/thread/cwvgn0vlb2yo797dvbq21rvwmv0fw6zr



Modified:
    subversion/trunk/subversion/tests/cmdline/dav_tests.py

Modified: subversion/trunk/subversion/tests/cmdline/dav_tests.py
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/dav_tests.py?rev=1924046&r1=1924045&r2=1924046&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/dav_tests.py (original)
+++ subversion/trunk/subversion/tests/cmdline/dav_tests.py Tue Feb 25 20:49:54 
2025
@@ -25,10 +25,7 @@
 ######################################################################
 
 # General modules
-import os, sys
-import re
-import socket
-import traceback
+import os, re
 
 # Our testing module
 import svntest
@@ -67,32 +64,6 @@ def connect_other_dav_server(sbox):
   svntest.actions.run_and_verify_svn([], svntest.verify.AnyOutput,
                                      'info', svntest.main.other_dav_root_url)
 
-#----------------------------------------------------------------------
-
-@SkipUnless(svntest.main.is_remote_http_connection_allowed)
-def connect_to_github_server(sbox):
-  "connect to GitHub's SVN bridge"
-
-  #github_mirror_url = 'https://github.com/apache/subversion/trunk'
-  # FIXME: Subversion's mirror on GitHub seems to randomly return gateway
-  #        errors (status 504), so use this more stable one instead.
-  github_mirror_url = 'https://github.com/apache/serf/trunk'
-
-  # Skip this test if we can't connect to the GitHub server.
-  # We check this here instead of in a SkipUnless() predicate decorator,
-  # because the decorator's condition function is called seeveral times
-  # during test execution.
-  try:
-    s = socket.create_connection(('github.com', 443), 2)  # 2-second timeout
-    s.close()
-  except:
-    etype, value, _ = sys.exc_info()
-    reason = ''.join(traceback.format_exception_only(etype, value)).rstrip()
-    svntest.main.logger.warn('Connection to github.com failed: ' + reason)
-    raise svntest.Skip
-
-  svntest.actions.run_and_verify_svn(None, [], 'info', github_mirror_url)
-
 
 ########################################################################
 # Run the tests
@@ -102,7 +73,6 @@ def connect_to_github_server(sbox):
 test_list = [ None,
               connect_plain_http_server,
               connect_other_dav_server,
-              connect_to_github_server,
              ]
 
 if __name__ == '__main__':


Reply via email to