Author: rinrab
Date: Mon May 4 14:59:52 2026
New Revision: 1933811
Log:
cmake: Use SEND_ERROR instead of FATAL_ERROR whenever we encounter an error.
The reason I believe this is a better one to use is because we don't have an
explicit need to fail instantly (which FATAL_ERROR does) but rather patiently
wait for the configuration to finish and only after that collect all the errors
so the user would deal with all of them at the same time. It's also usually a
good thing to be consistent with in such places.
* CMakeLists.txt
(everywhere): Change how we report errors.
Modified:
subversion/trunk/CMakeLists.txt
Modified: subversion/trunk/CMakeLists.txt
==============================================================================
--- subversion/trunk/CMakeLists.txt Mon May 4 14:53:52 2026
(r1933810)
+++ subversion/trunk/CMakeLists.txt Mon May 4 14:59:52 2026
(r1933811)
@@ -233,7 +233,7 @@ else()
endif()
if(SVN_ENABLE_FS_BASE)
- message(FATAL_ERROR "SVN_ENABLE_FS_BASE is NOT implemented and deprecated.")
+ message(SEND_ERROR "SVN_ENABLE_FS_BASE is NOT implemented and deprecated.")
endif()
if(BUILD_SHARED_LIBS OR SVN_BUILD_SHARED_FS OR SVN_BUILD_SHARED_RA)
@@ -775,7 +775,7 @@ if (MSVC)
endif()
if (NOT EXISTS "${CMAKE_SOURCE_DIR}/build/cmake/targets.cmake")
- message(FATAL_ERROR
+ message(SEND_ERROR
"The 'build/cmake/targets.cmake' file does NOT exist. "
"Use the following command to generate it:\n"
" python gen-make.py -t cmake"
@@ -885,7 +885,7 @@ if(SVN_ENABLE_TESTS)
RESULT_VARIABLE command_result
)
if (command_result)
- message(FATAL_ERROR "run_tests.py --create-python-venv failed.")
+ message(SEND_ERROR "run_tests.py --create-python-venv failed.")
endif()
string(STRIP "${command_output}" python3_test_executable)
@@ -934,7 +934,7 @@ if(SVN_ENABLE_TESTS)
)
if (command_result)
- message(FATAL_ERROR "list_tests.py failed.")
+ message(SEND_ERROR "list_tests.py failed.")
endif()
string(REGEX MATCHALL "[^\n\r]+" tests_list "${tests_list_output}")
