This is an automated email from the ASF dual-hosted git repository. hugh pushed a change to branch feat-sql-toolbar in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.
from 0e64ceb feat: update sql toolbar styling (#12164) add 4df968b feat: sql lab toolbar fixes (#12198) No new revisions were added by this update. Summary of changes: UPDATING.md | 12 + setup.py | 2 +- .../integration/chart_list/card_view.test.ts | 19 +- .../cypress/integration/chart_list/filter.test.ts | 5 +- .../cypress/integration/dashboard/controls.test.js | 5 +- .../cypress/integration/dashboard/filter.test.ts | 9 +- .../integration/dashboard/nativeFilters.test.ts | 59 ++ .../cypress/integration/dashboard/tabs.test.js | 6 +- .../integration/dashboard/url_params.test.js | 3 +- .../integration/dashboard_list/card_view.test.ts | 8 +- .../integration/dashboard_list/filter.test.ts | 2 +- .../integration/dashboard_list/list_view.test.ts | 2 +- .../cypress/integration/explore/chart.test.js | 2 +- .../explore/visualizations/area.test.js | 2 +- .../visualizations/big_number_total.test.js | 2 +- .../explore/visualizations/shared.helper.js | 2 +- .../explore/visualizations/sunburst.test.js | 2 +- superset-frontend/images/icons/filter.svg | 2 +- superset-frontend/package-lock.json | 666 +++++++++++---------- superset-frontend/package.json | 62 +- superset-frontend/spec/fixtures/mockState.js | 2 + .../components/AlteredSliceTag_spec.jsx | 6 +- .../components/SupersetResourceSelect_spec.tsx | 56 ++ .../components/fixtures/AlteredSliceTag.js | 6 +- .../spec/javascripts/dashboard/.eslintrc | 1 - .../components/nativeFilters/FilterBar_spec.tsx} | 41 +- .../FilterConfigurationLink_spec.tsx} | 40 +- .../nativeFilters/NativeFiltersModal_spec.tsx | 77 +++ .../components/nativeFilters/ScopingTree_spec.tsx} | 29 +- .../dashboard/fixtures/mockNativeFilters.js} | 42 +- .../util/getEffectiveExtraFilters_spec.js | 2 +- .../util/getFormDataWithExtraFilters_spec.ts | 10 +- .../datasource/ChangeDatasourceModal_spec.jsx | 4 +- .../spec/javascripts/explore/AdhocFilter_spec.js | 4 +- ...AdhocFilterEditPopoverSimpleTabContent_spec.jsx | 10 +- .../components/ControlPanelsContainer_spec.jsx | 2 +- .../components/ExploreViewContainer_spec.jsx | 50 +- .../explore/components/SaveModal_spec.jsx | 6 +- .../spec/javascripts/explore/controlUtils_spec.jsx | 14 - .../spec/javascripts/explore/fixtures.jsx | 1 - .../spec/javascripts/explore/store_spec.jsx | 13 - .../spec/javascripts/messageToasts/.eslintrc | 1 - .../sqllab/{Link_spec.jsx => IconTooltip_spec.jsx} | 19 +- .../spec/javascripts/sqllab/TableElement_spec.jsx | 8 +- .../spec/javascripts/utils/cacheWrapper_spec.ts | 83 +++ .../views/CRUD/welcome/SavedQueries_spec.tsx | 6 +- .../src/SqlLab/components/QueryTable.jsx | 18 +- .../src/SqlLab/components/RunQueryActionButton.tsx | 1 + .../src/SqlLab/components/ShowSQL.tsx | 5 +- .../src/SqlLab/components/SqlEditor.jsx | 29 +- .../src/SqlLab/components/TableElement.jsx | 34 +- superset-frontend/src/SqlLab/main.less | 2 +- superset-frontend/src/addSlice/App.tsx | 8 +- superset-frontend/src/chart/chartAction.js | 15 + superset-frontend/src/chart/chartReducer.js | 5 + .../src/common/components/Dropdown.tsx | 34 +- .../src/common/components/Modal/Modal.tsx | 9 +- .../src/common/components/common.stories.tsx | 1 + superset-frontend/src/common/components/index.tsx | 23 +- .../common/hooks/useChangeEffect.ts} | 26 +- .../Owner.ts => common/hooks/usePrevious.ts} | 21 +- superset-frontend/src/components/Button/index.tsx | 1 + .../src/components/DynamicPlugins/index.tsx | 181 ++++++ .../src/components/ErrorMessage/ErrorAlert.tsx | 23 +- .../ErrorMessage/ParameterErrorMessage.tsx | 57 +- .../src/components/{Link.tsx => IconTooltip.tsx} | 27 +- superset-frontend/src/components/ListView/types.ts | 8 +- superset-frontend/src/components/ListView/utils.ts | 17 +- .../src/components/SupersetResourceSelect.tsx | 116 ++++ superset-frontend/src/dashboard/App.jsx | 5 +- .../src/dashboard/actions/nativeFilters.ts | 137 +++++ .../dashboard/components/BuilderComponentPane.jsx | 110 ---- .../dashboard/components/BuilderComponentPane.tsx | 98 +++ .../src/dashboard/components/Dashboard.jsx | 15 +- .../src/dashboard/components/DashboardBuilder.jsx | 54 +- .../src/dashboard/components/Header.jsx | 27 +- ...hIntervalModal.jsx => RefreshIntervalModal.tsx} | 54 +- .../dashboard/components/SliceHeaderControls.jsx | 4 +- .../src/dashboard/components/StickyVerticalBar.tsx | 105 ++++ .../components/filterscope/FilterFieldItem.jsx | 4 +- .../filterscope/renderFilterScopeTreeNodes.jsx | 8 +- .../dashboard/components/gridComponents/Chart.jsx | 17 +- .../components/nativeFilters/CascadePopover.tsx | 171 ++++++ .../components/nativeFilters/ColumnSelect.tsx | 106 ++++ .../components/nativeFilters/FilterBar.tsx | 487 +++++++++++++++ .../components/nativeFilters/FilterConfigForm.tsx | 281 +++++++++ .../components/nativeFilters/FilterConfigModal.tsx | 513 ++++++++++++++++ .../nativeFilters/FilterConfigurationLink.tsx | 60 ++ .../components/nativeFilters/FiltersList.tsx | 67 +++ .../components/nativeFilters/ScopingTree.tsx | 64 ++ .../dashboard/components/nativeFilters/state.ts | 111 ++++ .../dashboard/components/nativeFilters/types.ts | 130 ++++ .../dashboard/components/nativeFilters/utils.ts | 180 ++++++ .../src/dashboard/containers/Chart.jsx | 28 +- .../src/dashboard/containers/Dashboard.jsx | 2 + .../src/dashboard/containers/FiltersBadge.tsx | 5 +- .../src/dashboard/reducers/getInitialState.js | 11 +- superset-frontend/src/dashboard/reducers/index.js | 2 + .../src/dashboard/reducers/nativeFilters.ts | 76 +++ .../src/dashboard/stylesheets/builder.less | 11 +- .../src/dashboard/stylesheets/grid.less | 7 - superset-frontend/src/dashboard/types.ts | 41 ++ .../util/charts/getEffectiveExtraFilters.ts | 2 +- .../util/charts/getFormDataWithExtraFilters.ts | 9 +- .../src/datasource/ChangeDatasourceModal.tsx | 17 +- .../src/datasource/DatasourceEditor.jsx | 4 +- superset-frontend/src/explore/AdhocFilter.js | 10 +- superset-frontend/src/explore/App.jsx | 5 +- .../src/explore/actions/saveModalActions.js | 5 +- .../AdhocFilterEditPopoverSimpleTabContent.jsx | 2 +- .../explore/components/ControlPanelsContainer.jsx | 15 +- .../explore/components/ExploreActionButtons.jsx | 8 +- .../src/explore/components/ExploreChartPanel.jsx | 5 +- .../explore/components/ExploreViewContainer.jsx | 566 +++++++++-------- .../src/explore/components/OptionControls.tsx | 6 +- .../components/{SaveModal.jsx => SaveModal.tsx} | 95 +-- .../components/controls/AnnotationLayerControl.jsx | 3 +- .../explore/components/controls/VizTypeControl.jsx | 28 +- superset-frontend/src/explore/constants.js | 15 +- superset-frontend/src/explore/controlUtils.js | 129 ++-- superset-frontend/src/explore/controls.jsx | 2 - .../src/explore/reducers/exploreReducer.js | 7 + superset-frontend/src/explore/store.js | 18 +- superset-frontend/src/featureFlags.ts | 2 + .../src/messageToasts/enhancers/withToasts.tsx | 30 +- .../annotation/types.ts => utils/cacheWrapper.ts} | 30 +- .../src/utils/getClientErrorObject.ts | 18 +- .../src/utils/getControlsForVizType.js | 35 +- superset-frontend/src/views/App.tsx | 167 +++--- .../src/views/CRUD/alert/AlertList.tsx | 10 +- .../src/views/CRUD/alert/AlertReportModal.tsx | 12 +- .../src/views/CRUD/alert/ExecutionLog.tsx | 2 +- .../components/AlertReportCronScheduler.test.tsx | 4 +- .../alert/components/AlertReportCronScheduler.tsx | 4 +- .../src/views/CRUD/chart/ChartList.tsx | 33 +- .../src/views/CRUD/dashboard/DashboardList.tsx | 29 +- .../src/views/CRUD/data/database/DatabaseList.tsx | 10 +- superset-frontend/src/views/CRUD/hooks.ts | 219 +++---- .../src/views/CRUD/welcome/ChartTable.tsx | 12 +- .../src/views/CRUD/welcome/DashboardTable.tsx | 12 +- .../src/views/CRUD/welcome/SavedQueries.tsx | 2 + .../src/visualizations/presets/MainPreset.js | 6 + superset-frontend/stylesheets/less/index.less | 8 +- superset-frontend/webpack.config.js | 1 + superset/app.py | 26 +- superset/charts/commands/export.py | 2 +- superset/charts/filters.py | 2 +- superset/commands/importers/v1/__init__.py | 5 + superset/common/query_object.py | 34 +- superset/config.py | 34 +- superset/connectors/sqla/models.py | 2 +- superset/dashboards/commands/importers/v1/utils.py | 9 + superset/dashboards/filters.py | 2 +- superset/dashboards/schemas.py | 4 + superset/databases/schemas.py | 1 + superset/datasets/commands/importers/v1/utils.py | 8 +- superset/db_engine_specs/base.py | 44 +- superset/db_engine_specs/postgres.py | 28 +- superset/db_engine_specs/presto.py | 16 +- superset/errors.py | 2 +- ..._Items_Sold_By_Product_Line.yaml => Games.yaml} | 50 +- .../examples/configs/charts/Games_per_Genre.yaml | 98 +++ .../configs/charts/Games_per_Genre_over_time.yaml | 120 ++++ ...duct_Line.yaml => Most_Dominant_Platforms.yaml} | 40 +- ...mes_That_Hit_100k_in_Sales_By_Release_Year.yaml | 92 +++ ...n.yaml => Popular_Genres_Across_Platforms.yaml} | 24 +- ...ilter.yaml => Publishers_With_Most_Titles.yaml} | 57 +- .../charts/Rise__Fall_of_Video_Game_Consoles.yaml | 135 +++++ ...op_10_Games_Proportion_of_Sales_in_Markets.yaml | 135 +++++ .../Total_Sales_per_Market_Grouped_by_Genre.yaml | 184 ++++++ .../{Filter.yaml => Vehicle_Sales_Filter.yaml} | 2 +- .../{Filter.yaml => Video_Game_Sales_Filter.yaml} | 31 +- .../configs/dashboards/Video_Game_Sales.yaml | 443 ++++++++++++++ ...ned_Sales_Data.yaml => cleaned_sales_data.yaml} | 2 +- .../datasets/examples/video_game_sales.yaml | 156 +++++ superset/examples/utils.py | 4 +- ...e.py => 73fd22e742ab_add_dynamic_plugins_py.py} | 30 +- superset/models/__init__.py | 1 + superset/models/core.py | 7 +- superset/models/{cache.py => dynamic_plugins.py} | 21 +- superset/reports/api.py | 1 + superset/reports/commands/execute.py | 10 +- superset/reports/commands/update.py | 12 +- superset/security/manager.py | 2 +- superset/sql_parse.py | 2 +- superset/templates/superset/basic.html | 4 +- superset/utils/core.py | 26 +- superset/views/__init__.py | 1 + superset/views/alerts.py | 51 +- superset/views/base.py | 2 +- superset/views/chart/views.py | 3 + superset/views/core.py | 10 +- superset/views/dynamic_plugins.py | 56 ++ superset/viz.py | 4 +- superset/viz_sip38.py | 4 +- tests/alerts_tests.py | 4 +- tests/base_tests.py | 6 +- tests/charts/api_tests.py | 77 +-- tests/charts/commands_tests.py | 14 +- tests/charts/schema_tests.py | 16 +- tests/core_tests.py | 25 - tests/dashboards/api_tests.py | 4 +- tests/dashboards/commands_tests.py | 14 +- tests/datasets/commands_tests.py | 4 +- tests/fixtures/importexport.py | 2 +- tests/fixtures/query_context.py | 78 +-- tests/query_context_tests.py | 88 ++- tests/reports/api_tests.py | 57 +- tests/reports/commands_tests.py | 55 ++ tests/reports/utils.py | 10 +- tests/security_tests.py | 2 + tests/superset_test_config.py | 1 + tests/tasks/async_queries_tests.py | 15 +- tests/utils_tests.py | 2 +- 214 files changed, 7163 insertions(+), 2004 deletions(-) create mode 100644 superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts create mode 100644 superset-frontend/spec/javascripts/components/SupersetResourceSelect_spec.tsx copy superset-frontend/{src/components/LastUpdated/LastUpdated.test.tsx => spec/javascripts/dashboard/components/nativeFilters/FilterBar_spec.tsx} (53%) copy superset-frontend/spec/javascripts/{explore/components/ColorScheme_spec.jsx => dashboard/components/nativeFilters/FilterConfigurationLink_spec.tsx} (55%) create mode 100644 superset-frontend/spec/javascripts/dashboard/components/nativeFilters/NativeFiltersModal_spec.tsx copy superset-frontend/spec/javascripts/{sqllab/QueryStateLabel_spec.jsx => dashboard/components/nativeFilters/ScopingTree_spec.tsx} (59%) copy superset-frontend/{src/messageToasts/containers/ToastPresenter.jsx => spec/javascripts/dashboard/fixtures/mockNativeFilters.js} (59%) rename superset-frontend/spec/javascripts/sqllab/{Link_spec.jsx => IconTooltip_spec.jsx} (67%) create mode 100644 superset-frontend/spec/javascripts/utils/cacheWrapper_spec.ts copy superset-frontend/{cypress-base/cypress/utils/readResponseBlob.ts => src/common/hooks/useChangeEffect.ts} (64%) copy superset-frontend/src/{types/Owner.ts => common/hooks/usePrevious.ts} (57%) create mode 100644 superset-frontend/src/components/DynamicPlugins/index.tsx rename superset-frontend/src/components/{Link.tsx => IconTooltip.tsx} (80%) create mode 100644 superset-frontend/src/components/SupersetResourceSelect.tsx create mode 100644 superset-frontend/src/dashboard/actions/nativeFilters.ts delete mode 100644 superset-frontend/src/dashboard/components/BuilderComponentPane.jsx create mode 100644 superset-frontend/src/dashboard/components/BuilderComponentPane.tsx rename superset-frontend/src/dashboard/components/{RefreshIntervalModal.jsx => RefreshIntervalModal.tsx} (81%) create mode 100644 superset-frontend/src/dashboard/components/StickyVerticalBar.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/ColumnSelect.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/FiltersList.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/ScopingTree.tsx create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/state.ts create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/types.ts create mode 100644 superset-frontend/src/dashboard/components/nativeFilters/utils.ts create mode 100644 superset-frontend/src/dashboard/reducers/nativeFilters.ts rename superset-frontend/src/explore/components/{SaveModal.jsx => SaveModal.tsx} (78%) copy superset-frontend/src/{views/CRUD/annotation/types.ts => utils/cacheWrapper.ts} (67%) copy superset/examples/configs/charts/{Total_Items_Sold_By_Product_Line.yaml => Games.yaml} (67%) create mode 100644 superset/examples/configs/charts/Games_per_Genre.yaml create mode 100644 superset/examples/configs/charts/Games_per_Genre_over_time.yaml copy superset/examples/configs/charts/{Overall_Sales_By_Product_Line.yaml => Most_Dominant_Platforms.yaml} (70%) create mode 100644 superset/examples/configs/charts/Number_of_Games_That_Hit_100k_in_Sales_By_Release_Year.yaml copy superset/examples/configs/charts/{Number_of_Deals_for_each_Combination.yaml => Popular_Genres_Across_Platforms.yaml} (77%) copy superset/examples/configs/charts/{Filter.yaml => Publishers_With_Most_Titles.yaml} (58%) create mode 100644 superset/examples/configs/charts/Rise__Fall_of_Video_Game_Consoles.yaml create mode 100644 superset/examples/configs/charts/Top_10_Games_Proportion_of_Sales_in_Markets.yaml create mode 100644 superset/examples/configs/charts/Total_Sales_per_Market_Grouped_by_Genre.yaml copy superset/examples/configs/charts/{Filter.yaml => Vehicle_Sales_Filter.yaml} (97%) rename superset/examples/configs/charts/{Filter.yaml => Video_Game_Sales_Filter.yaml} (68%) create mode 100644 superset/examples/configs/dashboards/Video_Game_Sales.yaml rename superset/examples/configs/datasets/examples/{Cleaned_Sales_Data.yaml => cleaned_sales_data.yaml} (99%) create mode 100644 superset/examples/configs/datasets/examples/video_game_sales.yaml copy superset/migrations/versions/{0c5070e96b57_add_user_attributes_table.py => 73fd22e742ab_add_dynamic_plugins_py.py} (71%) copy superset/models/{cache.py => dynamic_plugins.py} (63%) mode change 100755 => 100644 create mode 100644 superset/views/dynamic_plugins.py